WordPress.org

Making WordPress.org

Opened 10 months ago

Last modified 10 months ago

#3890 new enhancement

Trac: Increase preview file size limit

Reported by: melchoyce Owned by:
Milestone: Priority: normal
Component: Trac Keywords:
Cc:

Description

HTML preview not available, since the file size exceeds 1.0 MB. Try downloading the file instead.

Any chance we could get this file size increased? Makes it really hard to preview mockups in Trac, since they're often more than 1mb.

Change History (2)

#1 @dd32
10 months ago

An example of this is https://core.trac.wordpress.org/attachment/ticket/45073/Upgrade%20paths.jpg which is displayed inline in the comments thread, but is hidden in the attachment view as it's too large.

Displaying a preview for .diff files over 1M would actually not be ideal (The larger a diff is, the more processing time it takes to convert to HTML), so what we need is something specifically for images I feel.

Perhaps we should instead turn off force-download for /raw-attachment/ for image mime-types and have the comments link images directly to the image rather than the attachment screen?

If we can't turn off force-download of images, a quick-and-dirty workaround is to link to WordPress.com Photon instead (which might actually be easier, as less Trac changes..) - https://i0.wp.com/core.trac.wordpress.org/raw-attachment/ticket/45073/Upgrade%20paths.jpg

Last edited 10 months ago by dd32 (previous) (diff)

#2 @melchoyce
10 months ago

Perhaps we should instead turn off force-download for /raw-attachment/ for image mime-types and have the comments link images directly to the image rather than the attachment screen?

That would be perfect!

Note: See TracTickets for help on using tickets.