WordPress.org

Making WordPress.org

Opened 8 months ago

Closed 5 months ago

Last modified 4 months ago

#3896 closed enhancement (fixed)

Please add a 'needs-privacy-review' Workflow keyword

Reported by: garrett-eclipse Owned by: SergeyBiryukov
Milestone: Priority: normal
Component: Trac Keywords: has-patch commit
Cc:

Description (last modified by allendav)

Hello,

Following from recent meetings in #core-privacy we'd like to formally request a needs-privacy-review Workflow Keyword be added to Trac (Core/Meta/etc).

Originally proposed in Oct 17th 2018 meeting - https://make.wordpress.org/core/2018/10/19/core-privacy-office-hours-summary-17-october/

Following the existing definitions - https://make.wordpress.org/core/handbook/contribute/trac/keywords/

Proposed definition;
needs-privacy-review
A review is requested from #core-privacy with regards to the problem or the solution.

And should probably also add a 'has-privacy-review' tag to follow the other conventions with the definition of:
has-privacy-review
A review has been given from #core-privacy with regards to the problem or the solution.

This would allow developers to flag issues to #core-privacy people so they may conduct a review and indicate any privacy concerns.

Thank you

Attachments (2)

3896.diff (1.0 KB) - added by garrett-eclipse 8 months ago.
Add 'needs-privacy-review' and 'has-privacy-review' to wp-trac.js
3896.2.diff (1.6 KB) - added by garrett-eclipse 8 months ago.
Add keyword toggling for (has|needs)-privacy-review as per @netweb tip

Download all attachments as: .zip

Change History (18)

This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.


8 months ago

#2 @allendav
8 months ago

  • Description modified (diff)

#3 @garrett-eclipse
8 months ago

Looking at the Core Reports it would make sense to have a link to these tickets added under the 'Tickets Needing Feedback' section;
https://make.wordpress.org/core/reports/

#4 @netweb
8 months ago

  • Keywords needs-patch added

If someone wants to create a patch, adding the new keyword to wp-trac.js is what's required:

https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js#L6

@garrett-eclipse
8 months ago

Add 'needs-privacy-review' and 'has-privacy-review' to wp-trac.js

#5 follow-up: @garrett-eclipse
8 months ago

Thanks @netweb I attempted this in 3896.diff

I understand this adds it to the WorkFlow Keywords. But I was wondering about the custom report under 'Tickets Needing Feedback' found here;
https://make.wordpress.org/core/reports/

I didn't see the make site in the meta repo is it controlled somewhere else?

Appreciated, Cheers

#6 @garrett-eclipse
8 months ago

  • Keywords has-patch dev-feedback added; needs-patch removed

#7 in reply to: ↑ 5 ; follow-up: @netweb
8 months ago

Replying to garrett-eclipse:

Thanks @netweb I attempted this in 3896.diff

@garrett-eclipse If you're going to add the has-privacy-review then you'll also want to duplicate the functionality seen with similar keywords further down the code here. What this code does is acts as a toggle, if the keyword has-prvicacy-review is added then the needs-privacy-review keyword is removed.


I understand this adds it to the WorkFlow Keywords. But I was wondering about the custom report under 'Tickets Needing Feedback' found here;
https://make.wordpress.org/core/reports/

The reports listed on that link above come from reports generated via this page:

https://core.trac.wordpress.org/report

The custom keywords such as needs-screenshots and needs-privacy-review are not supported in these base reports. And for now just as needs-screenshots is not listed as a "report" on https://make.wordpress.org/core/reports/, needs-privacy-review would also not be listed, for now at least.

The Privacy component maintainers can edit the https://make.wordpress.org/core/components/privacy/ page, so adding a link to https://core.trac.wordpress.org/query?status=!closed&keywords=~needs-privacy-review on that page would be the way to go

@garrett-eclipse
8 months ago

Add keyword toggling for (has|needs)-privacy-review as per @netweb tip

#8 in reply to: ↑ 7 @garrett-eclipse
8 months ago

Replying to netweb:

@garrett-eclipse If you're going to add the has-privacy-review then you'll also want to duplicate the functionality seen with similar keywords further down the code here. What this code does is acts as a toggle, if the keyword has-prvicacy-review is added then the needs-privacy-review keyword is removed.

I missed that thanks for the tip @netweb updated in 3896.2.diff

Replying to netweb:

I understand this adds it to the WorkFlow Keywords. But I was wondering about the custom report under 'Tickets Needing Feedback' found here;
https://make.wordpress.org/core/reports/

The reports listed on that link above come from reports generated via this page:

https://core.trac.wordpress.org/report

The custom keywords such as needs-screenshots and needs-privacy-review are not supported in these base reports. And for now just as needs-screenshots is not listed as a "report" on https://make.wordpress.org/core/reports/, needs-privacy-review would also not be listed, for now at least.

The Privacy component maintainers can edit the https://make.wordpress.org/core/components/privacy/ page, so adding a link to https://core.trac.wordpress.org/query?status=!closed&keywords=~needs-privacy-review on that page would be the way to go

Thanks for pointing me in the right direction, I agree let's leave them off 'for now at least' until there's some traffic worthy of linking. And then we'll get it on the component page and reports page.

#9 @netweb
8 months ago

  • Keywords commit added; dev-feedback removed

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


7 months ago

This ticket was mentioned in Slack in #meta by garrett-eclipse. View the logs.


6 months ago

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


6 months ago

This ticket was mentioned in Slack in #meta by garrett-eclipse. View the logs.


5 months ago

#14 @SergeyBiryukov
5 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 8110:

Trac: Add has-privacy-review and needs-privacy-review keywords.

Props garrett-eclipse.
Fixes #3896.

#15 @SergeyBiryukov
5 months ago

In 8111:

Trac: Bump scripts version after [8109] and [8110].

See #4081, #3896.

#16 @garrett-eclipse
4 months ago

@SergeyBiryukov sorry to bother you I uploaded a patch in #4260 to modify the verbiage for these privacy keywords as they were discussed in #core-privacy meeting and official verbiage agreed upon there.

Note: See TracTickets for help on using tickets.