Plugin support URLs should 301 to enforce a trailing slash

[jonoaldersonwp]

E.g.,
​https://wordpress.org/support/plugin/wp-filebase should 301 to ​https://wordpress.org/support/plugin/wp-filebase/

[dd32]

@jonoaldersonwp This appears to already happen, are you seeing otherwise?

$ curl -I https://wordpress.org/support/plugin/wp-filebase
HTTP/2 301
server: nginx
date: Tue, 05 Feb 2019 08:35:47 GMT
content-type: text/html; charset=UTF-8
strict-transport-security: max-age=360
x-olaf: ⛄
x-redirect-by: WordPress
location: https://wordpress.org/support/plugin/wp-filebase/

[jonoaldersonwp]

Odd. Am I going mad?
Closing.

[jonoaldersonwp]

Aha, paginated states don't.

​https://wordpress.org/support/plugin/wp-filebase/page/2

[dd32]

Huh, weird. is_404() is true for paginated requests..

Ahhh super fun. A request to /support/plugin/* triggers this query in WP_Query.. and as there's only one page of posts on the site.. :)

SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts WHERE 1=1 AND wp_posts.post_type = 'post' AND (wp_posts.post_status = 'publish' OR ... ) ORDER BY wp_posts.post_date DESC LIMIT 0, 10

Looks like the Support forum custom views need some logic added to set is_404 = false and prevent the default query from running (since it's built elsewhere somehow)

[jonoaldersonwp]

Mwah ha ha, that's a fun one!

[dd32]

In 8213:

Support Forum: Override WP::handle_404() for Theme/Plugin/Review forum views when a matching plugin/theme is found.

Fixes #4072.