WordPress.org

Making WordPress.org

Opened 6 months ago

Closed 5 months ago

#4269 closed defect (maybelater)

Coding standards: Need to use numeric values instead of keywords in CSS.

Reported by: jankimoradiya Owned by:
Milestone: Priority: normal
Component: General Keywords: has-patch
Cc:

Description

I have noticed that, there are lots of occurrences of font-weight: bold; or font-weight: normal; in meta trac.

As per the CSS Coding Standards:

Font weights should be defined using numeric values (e.g. 400 instead of normal, 700 instead of bold).

Attachments (2)

#4269.diff (4.2 KB) - added by jankimoradiya 6 months ago.
#4269(2).diff (3.0 KB) - added by jankimoradiya 6 months ago.

Download all attachments as: .zip

Change History (8)

@jankimoradiya
6 months ago

#1 @man4toman
6 months ago

Hi @jankimoradiya
The RTL CSS files are automatically generated by the build tools then they don't need any patch.

#2 @jankimoradiya
6 months ago

Thank you @man4toman.

I have also updated those changes in style.css of WordPress.TV in my above patch. Is it correct?

This ticket was mentioned in Slack in #meta by jankimoradiya. View the logs.


6 months ago

This ticket was mentioned in Slack in #meta by jankimoradiya. View the logs.


6 months ago

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.


5 months ago

#6 @tellyworth
5 months ago

  • Resolution set to maybelater
  • Status changed from new to closed

Thanks for the submissions!

You're absolutely right that there are many instances across w.org that fail to meet this particular guideline. So many in fact that it's difficult to deal with them all, and some are in parts of the codebase that are in dire need of an overhaul. I'm going to close this ticket as maybelater, in the sense that we'll fix them either as updates are made to those themes, or when we have a more complete patch that covers most of the codebase. That's not a reflection on your effort, just the nature of an ageing codebase and limited resources.

Note: See TracTickets for help on using tickets.