Making WordPress.org

Opened 7 years ago

Closed 7 years ago

Last modified 23 months ago

#4403 closed defect (bug) (reported-upstream)

Make -- posts missing the ID called comments

Reported by: joyously Owned by: SergeyBiryukov
Priority: normal Milestone:
Component: Make (Get Involved) / P2 Keywords:
Cc:

Description

When subscribed to a Make blog, the email sent when a post is published has a link called "See all comments", and it has a fragment ID of #comments. But there is no ID in the post named comments, so the link just takes you to the top of the post.
The other link, for commenting, is to #respond, which does exist and works fine.

Here is an example from the email
​https://make.wordpress.org/core/2019/04/25/site-health-check-in-5-2/#comments

Change History (7)

This ticket was mentioned in ​Slack in #meta by joyously. ​View the logs.


7 years ago

#2 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Status new → accepted

#3 @SergeyBiryukov
7 years ago

#4640 was marked as a duplicate.

This ticket was mentioned in ​Slack in #meta by joyously. ​View the logs.


7 years ago

This ticket was mentioned in ​Slack in #meta by joyously. ​View the logs.


7 years ago

#6 @dd32
7 years ago

  • Resolution → reported-upstream
  • Status accepted → closed

#7 @ironprogrammer
23 months ago

For visibility, I've posted a PR for this: ​#236 Add comments id attribute.

I know this will be handled upstream, but think it would be great if this was supported along with the new theme planned for launch next week 🙌🏻.

Note: See TracTickets for help on using tickets.