WordPress.org

Making WordPress.org

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#4460 closed defect (fixed)

BuddyPress Trac's header doesn't apply the right style

Reported by: imath Owned by: johnjamesjacoby
Milestone: Priority: normal
Component: buddypress.org Keywords: has-screenshots has-patch
Cc:

Description

Hi,

It's been a while the https://buddypress.trac.wordpress.org/ header looks like the screen capture beneath :

https://cldup.com/OFU_m6fwoP.png

  • The BuddyPress logo seems to be missing,
  • The nav's style seems to be missing.

They are actually there ! But the Trac software is adding its own style to the header and it make them disappear. Here's the code that is messing (line 237 of https://s.w.org/style/trac/common/css/trac.css?v=117):

#header :link, #header :visited, #header :link:hover, #header :visited:hover {
 background: transparent;
 color: #555;
 margin-bottom: 2px;
 border: none;
 padding: 0;
}

Attached to this ticket is the patch I suggest to fix the issue on trac's header so that it looks like the screen capture below :

https://cldup.com/FvTeFxn7GM.png

Thanks a lot for your time.

Attachments (1)

4460.patch (1.6 KB) - added by imath 6 months ago.

Download all attachments as: .zip

Change History (10)

@imath
6 months ago

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


6 months ago

#2 @johnjamesjacoby
6 months ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 8839:

BuddyPress/bbPress: fix Trac header styling & links.

Updates bb-base theme header CSS to more strictly target header image and links.

Props imath. Fixes #4460.

#3 @johnjamesjacoby
6 months ago

In 8840:

BuddyPress/bbPress: more CSS cleanup, and bump version to today.

See #4460.

#4 @johnjamesjacoby
6 months ago

In 8841:

BuddyPress/bbPress: retina styling & toolbar cleanup.

Updates styling for header, nav, and buttons for retina displays.

(Also removes a few more toolbar items across both sites.)

See #4460.

#5 @johnjamesjacoby
6 months ago

In 8850:

BuddyPress/bbPress: specifically target :visited anchors.

This fixes darkened navigation links to visited Trac pages.

See #4460.

#6 @johnjamesjacoby
6 months ago

In 8851:

Trac (BuddyPress/bbPress): Bump CSS version from 20 to 21.

See #4460.

#7 @johnjamesjacoby
6 months ago

In 8852:

BuddyPress/bbPress: mobile responsive CSS improvements.

Fixes background color styling conflicts on primary navigation.

See #4460.

#8 @johnjamesjacoby
6 months ago

In 8853:

BuddyPress/bbPress: shrink logo on smaller screens.

Fixes a bug where the logo would get hidden behind the subnav on certain dimension displays.

See #4460.

#9 @johnjamesjacoby
6 months ago

In 8854:

BuddyPress/bbPress: more mobile device styling improvements.

Nudge the bbPress bee to the right of the logo mark.

Also switch hover/active color to white on mobile nav to improve contrast, and embiggen the subnav avatar.

See #4460.

Note: See TracTickets for help on using tickets.