WordPress.org

Making WordPress.org

Opened 6 years ago

Closed 4 years ago

Last modified 4 years ago

#456 closed defect (fixed)

Escape slashes not being stripped before displaying notification names/patterns

Reported by: stevegrunwell Owned by: coffee2code
Milestone: Priority: normal
Component: Profiles Keywords:
Cc:

Description

When creating notifications wrapped in quotes (for instance, "WP Password Generator"), I noticed that the resulting output of that notification displays the backslashes that are presumably there for escaping the quotes.

Steps to reproduce:

  1. While logged into WordPress.org, go to http://profiles.wordpress.org/(your username)/profile/notifications/
  2. Under the "Add New Notification" heading, create a notification with the following:
    • Notification Search String: "This string is wrapped in quotes"
    • Notification Name: A "test"

Upon saving, the notification list shows a notification like this (quotation marks escaped with a backslash):

Escaping backslashes in the notification name and pattern

When I go to edit the notification, the editable text fields also include the escaping backslash:

The notification edit screen with escaping slashes

Attachments (2)

escaped-strings.png (37.7 KB) - added by stevegrunwell 6 years ago.
Escaping backslashes in the notification name and pattern
edit-string.png (35.6 KB) - added by stevegrunwell 6 years ago.
The notification edit screen with escaping slashes

Download all attachments as: .zip

Change History (5)

@stevegrunwell
6 years ago

Escaping backslashes in the notification name and pattern

@stevegrunwell
6 years ago

The notification edit screen with escaping slashes

#1 @coffee2code
4 years ago

  • Owner set to coffee2code
  • Status changed from new to accepted

#2 @coffee2code
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed in [dotorg11218] as of 2015-11-24.

This ticket was mentioned in Slack in #meta by sam. View the logs.


4 years ago

Note: See TracTickets for help on using tickets.