WordPress.org

Making WordPress.org

Opened 3 months ago

Last modified 10 days ago

#4601 assigned enhancement

Init BP DevHub with the BP REST API Handbook

Reported by: imath Owned by: johnjamesjacoby
Milestone: Priority: normal
Component: buddypress.org Keywords: has-patch needs-testing
Cc:

Description

Hi !

To follow up this BP devel post and the latest conversations we had on slack about the developer.buddypress.org documentation site, you'll find attached to this ticket a patch to include the bporg-developer theme. It's a child theme of the wporg-developer theme and a nice companion to the (wporg) handbook plugin.

To include the parent theme and the handbook plugin, I've used svn:externals properties. I'm unsure it's the right way to do it but I wanted to avoid duplicating the wporg-developer theme and the handbook plugin into the buddypress.org "repository" and I thought it was a great way to keep the benefit of their future improvements.

You can use the patch or alternatively download and install the needed themes and plugins on developer.buddypress.org.

Needed plugins :

Needed themes if the patch is not used :

  • wporg-developer,
  • bporg-developer : The bporg-developer.zip file into the assets section of the GitHub release page is a specific version for the Meta repository. There's no README, all the code relative to the Restsplain plugin has been removed as we won't use it on developer.buddypress.org and a specific template has been added to display an "Under Construction" message for the Code Reference page.

PS: Once all this is installed on developer.buddypress.org, please make sure to update the option fresh_site to 1so that activating the bporg-developer theme from the live preview will generate the majority of needed pages and widgets.

About the activating process, I can handle it if I'm promoted as an Admin of developer.buddypress.org, otherwise, please activate plugins first and then the bporg-developer theme from the live preview feature of the Customizer. To start writing the BP REST API documentation, it would be awesome to add me (if not Admin) & @espellcaste as editors.

NB: the handbook plugin comes with a "Handbook Functionality for Pages" plugin we don't need to activate.

Our priority for the 5.0.0 release is the BP REST API documentation, that's why I don't include in this ticket the steps relative to the Code Reference part (I suggest to work on it later).

Thanks in advance for your help 😍

Attachments (9)

4601.diff (57.6 KB) - added by imath 3 months ago.
screenshot.png (143.9 KB) - added by imath 3 months ago.
buddypress.org/public_html/wp-content/themes/bporg-developer/screenshot.png (not included in the diff)
buddypress-logo.png (9.8 KB) - added by imath 3 months ago.
buddypress.org/public_html/wp-content/themes/bporg-developer/images/buddypress-logo.png (not included in the patch)
4601.2a.patch (530 bytes) - added by imath 5 weeks ago.
Option a: the WP Admin Bar at the top
4601.2b.patch (550 bytes) - added by imath 5 weeks ago.
The WP Admin Bar just over the #masthead
4601.3.patch (662 bytes) - added by imath 5 weeks ago.
Missing class
4601.4.patch (1.8 KB) - added by imath 5 weeks ago.
4601.5.patch (2.7 KB) - added by imath 5 weeks ago.
4601.6.patch (1.3 KB) - added by imath 10 days ago.

Download all attachments as: .zip

Change History (34)

@imath
3 months ago

@imath
3 months ago

buddypress.org/public_html/wp-content/themes/bporg-developer/screenshot.png (not included in the diff)

@imath
3 months ago

buddypress.org/public_html/wp-content/themes/bporg-developer/images/buddypress-logo.png (not included in the patch)

This ticket was mentioned in Slack in #buddypress by espellcaste. View the logs.


3 months ago

#2 @johnjamesjacoby
3 months ago

  • Keywords needs-testing added
  • Owner set to johnjamesjacoby
  • Status changed from new to assigned

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


3 months ago

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


8 weeks ago

This ticket was mentioned in Slack in #buddypress by netweb. View the logs.


6 weeks ago

#6 @johnjamesjacoby
5 weeks ago

In 9131:

BuddyPress: Initial commit of BuddyPress Developer child theme.

This is the first of a few additions/edits required to test & deploy the up-coming developer.buddypress.org site update.

Props imath. See #4601.

#7 @johnjamesjacoby
5 weeks ago

  • bporg-developer child theme Subversion external added
  • wporg-developer parent theme Subversion external added
  • handbook plugin Subversion external added
  • @espellcaste and @imath added as Administrators to site
  • Deployed to production
  • Handbook plugin activated
  • fresh_site set to 1 and customized (default content added)

There are some styling tweaks still to-do, specifically around the header/masthead & admin-bar and fixing their positions. (These should probably be made in bporg-developer/style.css)

@imath
5 weeks ago

Option a: the WP Admin Bar at the top

@imath
5 weeks ago

The WP Admin Bar just over the #masthead

#8 @imath
5 weeks ago

Hi @johnjamesjacoby

Thanks a lot for your work on the site, It looks awesome! 😍

Just added two patches to keep the admin bar at the top (4601.2a.patch​) or to move it just over the #masthead (4601.2b.patch) like it's the case for other website of the BuddyPress network.​

@imath
5 weeks ago

Missing class

#9 @imath
5 weeks ago

4601.3.patch includes a missing class. I've used the Customizer custom CSS on the staging site and forgot to update the theme. Sorry about this extra work.

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


5 weeks ago

#11 @johnjamesjacoby
5 weeks ago

In 9132:

BuddyPress: Styling tweaks for developer.buddypress.org.

Makes the admin-bar styling match the rest of BuddyPress.org.

Props imath. See #4601.

#12 @johnjamesjacoby
5 weeks ago

4601.3.patch is committed & deployed, but it looks like it still needs a few more changes (responsive, etc...)

Going to refresh my memory and see if there's a way to simplify the #wp-toolbar CSS.

#13 @johnjamesjacoby
5 weeks ago

In 9133:

BuddyPress: Enqueue bb-Base styling for developer.buddypress.org.

Remove redundant styling from bbpress/buddypress specific themes.

See #4601.

#14 @johnjamesjacoby
5 weeks ago

In 9134:

BuddyPress: styling tweaks to better blend the various parent/child themes.

See #4601.

#15 @johnjamesjacoby
5 weeks ago

In 9135:

BuddyPress: Toolbar tweaks for better site integration.

Fixes z-index issues with mobile.

See #4601.

#16 @johnjamesjacoby
5 weeks ago

In 9136:

BuddyPress: Toolbar z-index overrides.

Fixes toolbar overlapping mobile responsive dropdown on developer.buddypress.org.

See #4601.

#17 @johnjamesjacoby
5 weeks ago

Pretty sure we are OK to close this one. @imath go ahead and close when you're OK with everything?

#18 @imath
5 weeks ago

Thanks a lot @johnjamesjacoby I think we still need to apply 4601.3.patch and I saw some potential little fixes. But yes we’re touching goal 🙌

Just saw it was committed in [9132], sorry I missed it.

Last edited 5 weeks ago by imath (previous) (diff)

#19 @imath
5 weeks ago

Actually this commit [9133] has some damages :(

The landing page is no more using 3 columns:

https://cldup.com/PeqHHfMahd.png

The text is now very big:

https://cldup.com/nY0AXG0NKD.png

Could we avoid loading the bb-base style removing wp_enqueue_style( 'bb-base', content_url( 'themes' ) . '/bb-base/style.css' ); at line 19 of bporg-developer/functions.php to see how it goes ?

imho the mobile layout is secondary

@imath
5 weeks ago

#20 @imath
5 weeks ago

@johnjamesjacoby I think 4601.4.patch should fix the 3 columns layout issue and the text size issue.

Here are some screenshots:

3 columns on landing page

https://cldup.com/KmftVayn_G.png

Text size on BP API REST handbook page (The header and the WP Admin bar are both fixed)

https://cldup.com/NV3tyDYdet.png

#21 @imath
5 weeks ago

Hi @johnjamesjacoby

This time, I think the layout issue should be fixed on desktop and on mobile. I've improved my previous patch to make sure the header mobile display is similar to what we have on BuddyPress.org.

Home - 3 columns - mobile (on the left menu is cloded, on the right it's opened)

https://cldup.com/5msYtULGsV.jpg

Content - mobile (on the left menu is cloded, on the right it's opened)

https://cldup.com/qwJ_P2NtbJ.jpg

The layout on desktop is back to what we had in the first place except that the WP Admin Bar & the main header are fixed just like on BuddyPress.org

Home - 3 columns - desktop

https://cldup.com/1wzaFI3uzG.png

Content - desktop

https://cldup.com/r_4869hifc.png

The needed code for everything is into 4601.5.patch (PS: it replaces .4.patch)

Last edited 5 weeks ago by imath (previous) (diff)

@imath
5 weeks ago

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


4 weeks ago

#23 @johnjamesjacoby
4 weeks ago

In 9142:

BuddyPress: Unplug the bb-base styling dependency for Developer site.

Also includes styling tweaks for mobile that would normally be in bb-base.

See #4601. Props imath.

#24 @johnjamesjacoby
4 weeks ago

Still some styling improvements needed, but they aren't blockers IMO.

Discussion in Slack: https://wordpress.slack.com/archives/C02RQBYUG/p1568655020020400

@imath
10 days ago

#25 @imath
10 days ago

Hi @johnjamesjacoby

4601.6.patch should fix the header's responsiveness.

Here's a Without/With screenshot:

https://cldup.com/o14adKanLv.jpg

Note: See TracTickets for help on using tickets.