Making WordPress.org

Opened 5 weeks ago

Last modified 4 days ago

#4699 accepted enhancement

Provide compatible WP core updates depending on server PHP version from API

Reported by: afragen Owned by: SergeyBiryukov
Milestone: Priority: normal
Component: API Keywords: needs-patch 2nd-opinion servehappy

Description (last modified by SergeyBiryukov)

There has been discussion regarding having users of older versions of WP be able to update to the best version of WP core that their server configuration can run. This seems to be primarily limited by the PHP version. Please refer to #WP47797 for background.

Currently, if a user is running a version of PHP < 5.6.20 they can only install up to WP 5.1.x. However, the Update Now button will try to install the most current version of WP core, WP 5.2.2 at this moment. Unfortunately that results in a failure and there is no easy method of being able to upgrade to a best version.

Part of the discussion, especially in Slack, was that in lieu of needing to backport the patch in #WP47797 it would be more robust to modify the API to return a similar response.

A best version would correspond to the the most current version of WP that is capable of running/installing given the user's current server constraints.

The patch for #WP47797 works by taking the API response for something like, https://api.wordpress.org/core/version-check/1.7/?php=5.3 and changes the { "response": "upgrade" } to the offer that has the highest version that is less than or equal to the ?php=5.x query arg.

There are 3 obvious benefits.

  1. Users will be able to update to a more secure version of WP, in this case WP 5.1.x, with one click.
  2. WP 5.1.x includes the dashboard callout for updating to a more current version of PHP.
  3. This would reach every version of WP > 3.7 without the need for backporting.

Pinging @azaozz and @sergeybiryukov

Change History (6)

#1 @SergeyBiryukov
5 weeks ago

  • Description modified (diff)

#2 @SergeyBiryukov
5 weeks ago

  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

#3 @SergeyBiryukov
5 weeks ago

Thanks for the ticket!

Discussed this with the Meta team yesterday, the approach seems good so far. A patch is ready, testing it might take some time though, as that API is not open-sourced.

#4 @afragen
5 weeks ago

Great! If this approach works we can close #WP47797

#5 @desrosj
4 days ago

@SergeyBiryukov Is there any update on the status of this one?

This ticket was mentioned in Slack in #core by afragen. View the logs.

4 days ago

Note: See TracTickets for help on using tickets.