WordPress.org

Making WordPress.org

Opened 4 weeks ago

Closed 22 hours ago

#4763 closed task (fixed)

Gutenberg Props - WordPress 5.3

Reported by: jorgefilipecosta Owned by:
Milestone: Priority: high
Component: API Keywords:
Cc:

Description

Similar to #4442, we need to capture those who received props in Gutenberg and then ensure they're included in the 5.3 Credits API.
To collect the props, I queried the GitHub public API to retrieve all the usernames, names, and emails of emails that had a PR merged in the repository.
Then I added this information on a spreadsheet and used mappings from email to wp.org username available in public spreadsheets shared in issues similar to this one. I also took advantage of the official GitHub profile mappings. Props to @ocean90 for inputting in the spread the WP.org <-> to Github mappings.
Many usernames were still missing. I searched around the internet to try to find them and also messaged some people and asked for them.

Some usernames are still missing; I will create an issue in the Gutenberg repository pinging the remaining usernames and ask them to provide their username and connect their Github to their WP.org profile.
@ocean90 Would it be possible to update the official mappings in the spreadsheet? Maybe some people connected the profiles meanwhile.

The spreadsheet I used is this one:
https://docs.google.com/spreadsheets/d/1Z_D75_o-QYiW7tzP93kSoRz6GfiUj11EZ_BSKCln3a0/edit?usp=sharing

Usernames on column "Map Result" on the first column are the ones that should receive props.

I am pinging @jorbin @audrasjb @coffee2code @SergeyBiryukov @JeffPaul, who are usually involved in this task.
Please let me know if anything is missing so we can move this task forward.

Change History (7)

#1 @JeffPaul
4 weeks ago

I've gone through and reviewed those missing a .ORG username and have been unable to identify any that can be added. So unless those folks respond to the GitHub issue pinging them, I think this is as complete a listing of folks that we can manage.

One thing I'd recommend we consider is adding a Changelog Entry to the Gutenberg PR template (example) so that folks submitting a PR could include their .ORG username as well as credit anyone from the linked issue who should also receive a prop.

#2 @coffee2code
4 weeks ago

Via either an email address search or checking details of w.org accounts matching their GitHub usernames, I've managed to associate three more accounts:

GitHub username => w.org username

ajlende => ajlende
codesue => codesue
sambgordon => samgordondev

#3 @jorgefilipecosta
2 weeks ago

Thank you for the help in doing the mapping @JeffPaul, @coffee2code. I updated the spreadsheet with the new mappings, we were able to find, and with the usernames of the people that answered the issue.

One thing I'd recommend we consider is adding a Changelog Entry to the Gutenberg PR template (example) so that folks submitting a PR could include their .ORG username as well as credit anyone from the linked issue who should also receive a prop.

Ideally, we would have a bot that commented when someone without a linked WP.org account submits a PR. But suggesting people to connect their accounts on the PR template seems like a good idea for the short-term cc: @youknowriad.

#4 @desrosj
2 weeks ago

I worked on compiling props for 5.3 today. This is the list that I came up with: https://docs.google.com/spreadsheets/d/1u0kjf4iSO9M5s0ZsSlVUUrPxmm4OeZNtx5CEae_IUqg/edit?usp=sharing

I created this list by running the following command:

git shortlog -sen 3f9b083568d7244b2d6c07d7300c188548c192b9...1b3274fd6ee4bba03472f9b7f99f60d5ff3f3df1 > gutenprops.txt

This gave all contributions from tagging version 5.4 to 6.5. I then spot checked each cherry picked PR that was merged into trunk from versions 6.6 and 6.7 (see Core-47843, Core-48381, and Core-48447) to make sure anyone contributing for the first time in the release cycle was credited.

I added each person only in my list to the original Gutenberg Props spreadsheet so that their usernames can be found/entered. There are still 8 contributors in my list of 5.3 contributors that are still missing .org usernames.

#5 @coffee2code
13 days ago

Great work, all!

Here are a couple more associations:

GitHub => w.org username
Fabian Kägy => fabiankaegy
Michael Chavez => mchavezi

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.


8 days ago

#7 @coffee2code
22 hours ago

  • Resolution set to fixed
  • Status changed from new to closed

Now that WP 5.3 has been released, looks like this can be closed.

Please file any overlooked props at this point in #4838 (re-opening it if it's closed at the time).

Efforts for scripting general props-parsing and w.org username correlation should happen on a dedicated ticket.

Note: See TracTickets for help on using tickets.