WordPress.org

Making WordPress.org

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#497 closed enhancement (fixed)

Increase font size in Trac inputs

Reported by: johnbillion Owned by: DrewAPicture
Milestone: Priority: normal
Component: Trac Keywords: has-patch commit
Cc:

Description

Maybe I'm getting old, but the font size in the text inputs and textareas on Trac is a bit small. It's 11px currently. Can we bump it up to 12 or 13px?

Attachments (3)

497-meta-chrome-incorrectly-reports-13.png (313.5 KB) - added by iandunn 5 years ago.
497-meta-chrome-correctly-reports-11.png (326.2 KB) - added by iandunn 5 years ago.
497.diff (600 bytes) - added by kpdesign 5 years ago.
Increase font size for text input and textarea

Download all attachments as: .zip

Change History (19)

#1 @kpdesign
5 years ago

I second this request. The font size in the ticket description and comments is 14px, so perhaps we should increase the font size to 14px to match them?

#2 @SergeyBiryukov
5 years ago

I see font-size: 13px in Firebug: http://cl.ly/image/25030G36071B. Is that not what you see?

#3 @johnbillion
5 years ago

Looks like there's an inconsistency between Chrome and Firefox. Thetextarea in Firefox inherits that value, but it doesn't in Chrome.

#4 @SergeyBiryukov
5 years ago

Hmm, I see 13px in Chrome too: http://cl.ly/image/0R2w1Q0H0E0f. Perhaps a Mac OS vs. Windows inconsistency?

#5 @iandunn
5 years ago

I'm seeing it at 11px too on Core and Meta Tracs, although Chrome Dev Tools gets confused by the cascading values and incorrectly reports it as 13px (which I've seen it do before on other sites).

It's correctly reported as 11px on the Computed tab, but wrongly as 13px on the Styles tab (see screenshots).

If you use dev tools to manually override the font-size with 12px, you'll see that it increases.

#6 @nacin
5 years ago

Cross-browser styling of form fields (especially selects) are painful. Happy to make any adjustments here.

#7 @samuelsidler
5 years ago

Stylesheets are here for anyone interested.

@kpdesign
5 years ago

Increase font size for text input and textarea

#8 @kpdesign
5 years ago

  • Keywords has-patch added

497.diff increases the font size for the text inputs and textarea in the new ticket form, and the ticket comment textarea for existing tickets.

#9 @Otto42
5 years ago

I see it as 13px in Chrome and Firefox. Looks the same in both to me.

So, the question isn't just a matter of bumping it up in the CSS. If some browsers are behaving differently in the CSS, then we need to understand why and what's going on.

Chrome reports it as 13px for me, and it looks identical to the same page in Firefox.

This ticket was mentioned in IRC in #wordpress-meta by sams. View the logs.


5 years ago

#11 @kpdesign
5 years ago

#770 was marked as a duplicate.

#12 @melchoyce
5 years ago

  • Keywords ui-feedback added

@otto42 are you positive you're seeing 13px? I see 11px on Chrome: https://cloudup.com/c2tQHHLE3ts

#13 @johnbillion
4 years ago

  • Keywords commit added; ui-feedback removed

For the love of my eyesight, somebody please commit this patch.

#14 @DrewAPicture
4 years ago

  • Owner set to DrewAPicture
  • Status changed from new to accepted

#15 @drewapicture
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 1934:

Trac: Improve readability in text and textarea form inputs by explicitly declaring the font-size as 13px.

This change is an attempt at addressing an issue exhibited by some browser in not correctly deducing the font size through inheritance.

Bumps the scripts version.

Fixes #497.

#16 @drewapicture
4 years ago

In 1935:

Trac: Re-bump the script version following [1934].

See #497.

Note: See TracTickets for help on using tickets.