Making WordPress.org

Opened 5 years ago

Closed 20 months ago

#4995 closed defect (bug) (fixed)

Page title format incorrect on support article category templates

Reported by: jonoaldersonwp's profile jonoaldersonwp Owned by:
Milestone: Priority: lowest
Component: HelpHub (wordpress.org/documentation) Keywords: seo analytics needs-patch
Cc:

Description

On pages like this - https://wordpress.org/support/category/block-editor/page/2/ - the page title format for pagination components is incorrect.

E.g., on https://wordpress.org/support/category/block-editor/page/2/, it is Block Editor | - page 2 | WordPress.org. This should be changed to Block Editor - Page 2 of X | WordPress.org (where X is the total pages).

NB, I'm not sure which Component this should be reported as, sorry!

Attachments (1)

4995.diff (719 bytes) - added by dufresnesteven 5 years ago.
This patch updates the page x of x section without moving it to the left of the '|'. We could also do some string replacement to push it over if this doesn't cut it :) Unsure if its worth it..

Download all attachments as: .zip

Change History (8)

#1 @Otto42
5 years ago

  • Component changed from General to Support Forums

#2 @SergeyBiryukov
5 years ago

  • Component changed from Support Forums to HelpHub

@dufresnesteven
5 years ago

This patch updates the page x of x section without moving it to the left of the '|'. We could also do some string replacement to push it over if this doesn't cut it :) Unsure if its worth it..

#3 follow-up: @dd32
5 years ago

  • Keywords needs-patch added

@dufresnesteven 4995.diff looks good for the article category pages, but not so much for other paged views - such as forums

For example, https://wordpress.org/support/forum/accessibility/page/2/ now has the title:
Accessibility Page 2 of 0 | WordPress.org
which is why the existing code is - Page 2, to produce Accessibility - Page 2 | WordPress.org

#4 @dd32
5 years ago

See also #4796

#5 in reply to: ↑ 3 @dufresnesteven
5 years ago

Thanks for the catch. I'll try again.

Replying to dd32:

@dufresnesteven 4995.diff looks good for the article category pages, but not so much for other paged views - such as forums

For example, https://wordpress.org/support/forum/accessibility/page/2/ now has the title:
Accessibility Page 2 of 0 | WordPress.org
which is why the existing code is - Page 2, to produce Accessibility - Page 2 | WordPress.org

#6 @dufresnesteven
5 years ago

After carefully deliberation, I have concluded that my whacked out environment will not allow me to deal with this properly :(.

#7 @jonoaldersonwp
20 months ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.