WordPress.org

Making WordPress.org

Opened 5 weeks ago

Last modified 5 weeks ago

#5054 new enhancement

GitHub integration: Sync pull request description

Reported by: noisysocks Owned by:
Milestone: Priority: normal
Component: Trac Keywords:
Cc:

Description

It would be useful to sync the pull request's description to the linked Trac ticket. Descriptions often contain important information such as testing instructions or implementation details, and can be considered the first comment in a pull request.

Attachments (1)

Screen Shot 2020-02-24 at 12.32.46.png (137.8 KB) - added by noisysocks 5 weeks ago.
The PR description / first comment

Download all attachments as: .zip

Change History (6)

@noisysocks
5 weeks ago

The PR description / first comment

#1 @dd32
5 weeks ago

The only pitfall I can see here is that the Markdown syntax between PR's and Trac comments differ slightly, so some things will come over a little scrambled. But for most basic things it should work just fine.

I'd probably suggest we enable the email notifications for the "PR has been linked to this ticket" comment if it contains such a comment too.

#2 @dd32
5 weeks ago

In 9531:

Trac: Github PRs: Include the PR bodytext in the Trac notification.

This should help include some more context in the PRs and also make it easier to keep all pertitant information in one place (Trac).

See #5054.

#3 @dd32
5 weeks ago

r9531 seems to work in my testing, but let's see what it actually looks like once some production PRs are created..

I didn't enable Email notifications for the comment, but that's the obvious next thing before this is closed (Assuming this hasn't broken Trac :) )

#4 follow-up: @dd32
5 weeks ago

In 9532:

Trac: Github PRs: Enable email notifications for the new-PR-linked comment.

See #5054.

#5 in reply to: ↑ 4 @dd32
5 weeks ago

Replying to dd32:

In 9532:

Trac: Github PRs: Enable email notifications for the new-PR-linked comment.

See #5054.

Doesn't look like this worked.. I don't see any notifications for https://core.trac.wordpress.org/ticket/49495#comment:4

Note: See TracTickets for help on using tickets.