WordPress.org

Making WordPress.org

Opened 9 months ago

Closed 6 months ago

#5054 closed enhancement (fixed)

GitHub integration: Sync pull request description

Reported by: noisysocks Owned by:
Milestone: Priority: normal
Component: Trac Keywords:
Cc:

Description

It would be useful to sync the pull request's description to the linked Trac ticket. Descriptions often contain important information such as testing instructions or implementation details, and can be considered the first comment in a pull request.

Attachments (1)

Screen Shot 2020-02-24 at 12.32.46.png (137.8 KB) - added by noisysocks 9 months ago.
The PR description / first comment

Download all attachments as: .zip

Change History (13)

@noisysocks
9 months ago

The PR description / first comment

#1 @dd32
9 months ago

The only pitfall I can see here is that the Markdown syntax between PR's and Trac comments differ slightly, so some things will come over a little scrambled. But for most basic things it should work just fine.

I'd probably suggest we enable the email notifications for the "PR has been linked to this ticket" comment if it contains such a comment too.

#2 @dd32
9 months ago

In 9531:

Trac: Github PRs: Include the PR bodytext in the Trac notification.

This should help include some more context in the PRs and also make it easier to keep all pertitant information in one place (Trac).

See #5054.

#3 @dd32
9 months ago

r9531 seems to work in my testing, but let's see what it actually looks like once some production PRs are created..

I didn't enable Email notifications for the comment, but that's the obvious next thing before this is closed (Assuming this hasn't broken Trac :) )

#4 follow-up: @dd32
9 months ago

In 9532:

Trac: Github PRs: Enable email notifications for the new-PR-linked comment.

See #5054.

#5 in reply to: ↑ 4 ; follow-up: @dd32
9 months ago

Replying to dd32:

In 9532:

Trac: Github PRs: Enable email notifications for the new-PR-linked comment.

See #5054.

Doesn't look like this worked.. I don't see any notifications for https://core.trac.wordpress.org/ticket/49495#comment:4

#6 @dd32
8 months ago

#5143 was marked as a duplicate.

#7 in reply to: ↑ 5 @dd32
8 months ago

Replying to dd32:

Replying to dd32:

In 9532:

Trac: Github PRs: Enable email notifications for the new-PR-linked comment.

See #5054.

Doesn't look like this worked.. I don't see any notifications for https://core.trac.wordpress.org/ticket/49495#comment:4

Testing against my own Trac instance, it looks like the RPC call is being processed correctly.

This ticket was mentioned in Slack in #meta by dd32. View the logs.


8 months ago

#10 @garrett-eclipse
6 months ago

@dd32 just an FYI I'm not seeing notifications from PRs attached to Trac. If people don't comment on the ticket after making the PR then it's silent and watchers aren't aware there's a new patch.
Specifically speaking on the PR#322 on this ticket #43994
*Commenting here as I followed the duplicate trail to this ticket.

A second thought is there's not a comment number that's linked to the comment so you can't share them or point them out directly like you can for other comments in Trac.

#11 @dd32
6 months ago

just an FYI I'm not seeing notifications from PRs attached to Trac. If people don't comment on the ticket after making the PR then it's silent and watchers aren't aware there's a new patch.

Correct. Email notifications from Trac don't work, no idea why, the RPC calls are correct but Trac isn't sending notifications.

#12 @dd32
6 months ago

I'm going to re-open #5143 and close this ticket as fixed.

#13 @dd32
6 months ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.