Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#5064 closed defect (bug) (fixed)

Make WordPress Design site > Handbook page improvements

Reported by: fahimmurshed's profile fahimmurshed Owned by: coffee2code's profile coffee2code
Milestone: Priority: normal
Component: Handbooks Keywords:


Check this link. #wordpress-org link tag not working.

Please watch this

Also, I would like to request to correct the broken links.

Change History (6)

#1 @SergeyBiryukov
4 years ago

  • Component changed from Site to Make (Get Involved) / P2

#2 @SergeyBiryukov
4 years ago

  • Keywords reporter-feedback removed

Thanks for the ticket! Looks like the link is not working due to conflicting IDs on the page:

<body id="wordpress-org" ...>
<h2 class="toc-heading" id="wordpress-org" tabindex="-1">

#3 @fahimmurshed
4 years ago

Thanks @SergeyBiryukov for taking care of this :)

#4 @coffee2code
3 years ago

  • Component changed from Make (Get Involved) / P2 to Handbooks

#5 @coffee2code
3 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 10938:

Handbooks, ToC: Prevent potential auto-generated ToC heading IDs from conflicting with those in theme markup.

Ensures ToC heading links are unique so that in such cases the links actually lead to the section heading and not some other part of the page.

This is very theme-specific and would need adjustments if the theme employs new potentially-conflicting markup IDs.

Props fahimmurshed, SergeyBiryukov, coffee2code.
Fixes #5064.

#6 @coffee2code
3 years ago

In 11118:

Handbooks, ToC: Fix ToC heading ID auto-generation to account for IDs used at different heading levels.

Props oglekler, coffee2code.
See #5064.
Fixes #5705.

Note: See TracTickets for help on using tickets.