WordPress.org
Get WordPress

Making WordPress.org

Opened 5 years ago

Closed 4 years ago

#5066 closed defect (bug) (fixed)

Arbitrary strings should not break theme archives

Reported by: jonoaldersonwp's profile jonoaldersonwp Owned by: dd32's profile dd32
Milestone: Priority: low
Component: Theme Directory Keywords: seo
Cc:

Description

Adding arbitrary query parameters to themes URLs, like ​https://wordpress.org/themes/?hello, shouldn't result in zero results being returned.

These parameters should be ignored.

Change History (1)

#1 @dd32
4 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 9729:

Theme Directory: Ignore any query params when matching a Backbone route.

This isn't straight forward, as Backbone doesn't support query params, at all. This strips them out of the core Backbone.History object.

Fixes #5066.

Note: See TracTickets for help on using tickets.