WordPress.org

Making WordPress.org

Opened 2 months ago

Last modified 2 months ago

#5343 accepted enhancement

SVN: Update precommit hooks to block 'compressed' files.

Reported by: Ipstenu Owned by: Otto42
Milestone: Priority: normal
Component: Plugin Directory Keywords:
Cc:

Description

Pre-commit hooks should block the following prohibited filetypes:

  • .phar
  • .zip
  • .7z
  • .tar.[whatever]
  • .rar
  • .dmg

Those are basically the common ones people make mistakes with. It should apply to themes and plugins SVN.

Change History (3)

#1 @Otto42
2 months ago

  • Owner set to Otto42
  • Status changed from new to accepted

#2 @Otto42
2 months ago

Plugins SVN has a pre-commit script, we can add to those.

Themes does not, but theme authors don't commit directly there anyway, they only upload ZIP files through the theme uploader. Perhaps something can be added to theme-check, if needed.

#3 @dd32
2 months ago

Plugins SVN has a pre-commit script, we can add to those.

A systems request will be needed for that, shouldn't be too big - just need to make sure it only applies to Adding/updating files and not deleting.

Perhaps something can be added to theme-check, if needed.

100% this - although I don't know how often it is for compressed files to be included in Themes. Certainly won't be of any harm.

It might help knock back some of the Themes that include plugin zips inside them when initially submitted for review, but not many themes do that anymore since a certain large marketplace that did that forced them over to the TGMPA.

Note: See TracTickets for help on using tickets.