WordPress.org

Making WordPress.org

Opened 5 years ago

Closed 5 years ago

#540 closed enhancement (fixed)

Hide "Download WordPress" button on smallest breakpoint

Reported by: zamfeer Owned by: coffee2code
Milestone: Priority: normal
Component: General Keywords: has-patch ui-feedback
Cc:

Description

This button takes up a lot of real estate on phones without serving a purpose. I don't think there's a use case for downloading WP onto a phone, but correct me if I'm wrong

Attachments (5)

download-wp.png (88.8 KB) - added by zamfeer 5 years ago.
screenshot of developer.wordpress.org on iPhone 4s
540-css.diff (1022 bytes) - added by ryelle 5 years ago.
540-header.diff (517 bytes) - added by ryelle 5 years ago.
540.png (132.0 KB) - added by ryelle 5 years ago.
540-small.png (87.5 KB) - added by ryelle 5 years ago.

Download all attachments as: .zip

Change History (10)

@zamfeer
5 years ago

screenshot of developer.wordpress.org on iPhone 4s

#1 @Otto42
5 years ago

I would support making it link to the mobile page instead, so that users could get links to the various Apps.

#2 @ocean90
5 years ago

Related: #526

@ryelle
5 years ago

@ryelle
5 years ago

@ryelle
5 years ago

@ryelle
5 years ago

#3 @ryelle
5 years ago

I don't think the big download banner needs to exist on the inner pages, it should only be on the homepage. It takes a lot of vertical space on smaller screens. 540-header.diff adds a conditional around the button to only display it on / (there isn't a way to do this CSS-only, as there aren't any page-specific classes on the static pages).

Since the big banner isn't on interior pages anymore, we should leave the button visible in the menu. I tested this on iPad, and obviously the menu didn't fit- so I bumped up the mobile-menu breakpoint up so the button shows up in the dropdown menu. 540-css.diff

What this looks like now:

FWIW this also fixes the issue norcross noted on twitter, since that button isn't used on profiles anymore.

I would support making it link to the mobile page instead, so that users could get links to the various Apps.

There is the "Looking for mobile apps" section on /download/, which we could highlight more if on a smaller screen.

#4 @melchoyce
5 years ago

  • Keywords has-patch ui-feedback added

Giant +1 from me.

#5 @coffee2code
5 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 1391:

wp4.css: Show download button in mobile menu since mobile download banner is no longer shown except on homepage.

Fixes #540.
Props ryelle.

Note: See TracTickets for help on using tickets.