WordPress.org

Making WordPress.org

Opened 6 months ago

Closed 6 months ago

#5720 closed defect (fixed)

Theme upload can fail on locale sites

Reported by: dd32 Owned by:
Milestone: Priority: normal
Component: Theme Directory Keywords:
Cc:

Description

The Theme directory is available on locale sites, for example Romanian: https://ro.wordpress.org/themes/

It appears that uploads from those sites can fail, due to the translation of the commit message.

The commit message probably shouldn't be localised.

svn ci --non-interactive -m 'Versiune nouă a ThemeName - 1.2.3' ...

svn: E000022: Error normalizing log message to internal format
svn: E000022: Can't convert string from native encoding to 'UTF-8':
svn: E000022: Versiune noua a ThemeName - 1.2.3

Change History (4)

#1 @dd32
6 months ago

In 10931:

Theme Directory: When adding themes to SVN, don't translate the commit message.

See #5720.

#2 follow-up: @dd32
6 months ago

[10931] should help here, however I suspect theme names themselves could trigger it too.

#3 in reply to: ↑ 2 ; follow-up: @vladytimy
6 months ago

Replying to dd32:

[10931] should help here, however I suspect theme names themselves could trigger it too.

Not sure if this is a general rule for all locales (I think it should be) but we never translate themes (nor plugins) name.

#4 in reply to: ↑ 3 @dd32
6 months ago

  • Resolution set to fixed
  • Status changed from new to closed

Replying to vladytimy:

Replying to dd32:

[10931] should help here, however I suspect theme names themselves could trigger it too.

Not sure if this is a general rule for all locales (I think it should be) but we never translate themes (nor plugins) name.

Some locales do transliterate them though.

I was more of thinking of a Theme name itself containing a non-ascii character though, nothing says they must be ascii only.

That being said, I'm actually going to close this anyway since I don't think it's very likely. We've got monitoring in place to pick up failed commands like this (Which is why I knew about this issue in the first place) and so that'll get triggered again if a theme name ever does trigger it.

Note: See TracTickets for help on using tickets.