Making WordPress.org

Opened 2 years ago

Closed 2 years ago

#6038 closed defect (bug) (fixed)

Broken style on core.trac page

Reported by: krishaweb's profile krishaweb Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Trac Keywords: needs-patch has-screenshots
Cc:

Description

Found broken style issue in the core.trac when checking the latest tickets.

Ref: https://tinyurl.com/yb59bmft

Change History (4)

#1 @SergeyBiryukov
2 years ago

  • Component changed from General to Trac

#2 follow-up: @dd32
2 years ago

This was mostly fixed by [11464], but took a while for it to be reflected upon trac as it doesn't reload it's templates that often.

There's still an issue in that the JS overlay needs to be updated to detect the new header height.

Since it's Javascript, we should probably update the code to position it properly, rather than relying upon magic numbers in CSS.

https://cldup.com/Vg2HnQcq57.png

#3 in reply to: ↑ 2 @dd32
2 years ago

Replying to dd32:

There's still an issue in that the JS overlay needs to be updated to detect the new header height.

Fixed via #6070 & [11502].

Since it's Javascript, we should probably update the code to position it properly, rather than relying upon magic numbers in CSS.

Next commit, which also fixes mobile views with a width < 770px.

#4 @dd32
2 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 11540:

Trac: Calculate the correct Core Ticket popover position via Javascript upon opening the popover.

Thix fixes the positioning for mobile views (<770px) and ensures that future header changes don't need the CSS updating.

Fixes #6038.

Note: See TracTickets for help on using tickets.