Making WordPress.org

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#6268 closed defect (bug) (fixed)

wporg-developer theme shouldn't use `get_stylesheet_directory()` as it can be used as a parent theme

Reported by: imath's profile imath Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Developer Hub Keywords: has-patch
Cc:

Description

Hi (again),

the bporg-developer theme is a child theme of wporg-developer and it's too bad we have to copy paste the editor-style.css file into it instead of using the one provided by the parent theme.

I suggest to use get_template_directory() instead of get_stylesheet_directory()

Attachments (1)

6268.patch (1.3 KB) - added by imath 2 years ago.

Download all attachments as: .zip

Change History (5)

@imath
2 years ago

#1 @imath
2 years ago

  • Keywords has-patch added

#2 @dd32
2 years ago

  • Owner set to dd32
  • Status changed from new to accepted

the bporg-developer theme is a child theme of wporg-developer and it's too bad we have to copy paste the editor-style.css file into it instead of using the one provided by the parent theme.

@imath The WordPress.org Developer theme is likely to get some major visual changes made to it in the future that may require you to re-think this. Ultimately a new visual design will flow from the new news blog to all sites, and have them rebuilt using blocks in that process.

But for now, no issues with this patch.

#3 @dd32
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 11765:

Developer theme: Allow for the theme to be used as a parent theme.

Props imath.
Fixes #6268.

#4 @imath
2 years ago

Thanks a lot for the info about the major changes (involving block templates) @dd32 👌

Note: See TracTickets for help on using tickets.