Redirect loop on Make when visiting wp-admin without a user role

[iandunn]

If a logged-in user attempts to visit /wp-admin on some Make sites that they don’t have access to, they get stuck in a redirect loop.

e..g, requesting ​http://make.wordpress.org/training/wp-admin redirects to ​https://make.wordpress.org/training/wp-admin/edit.php?post_type=handbook and then fails.

It doesn’t affect all of the sites, though. I’m seeing it on /training, /docs, /core, and /meta, but not on /community. I didn’t test beyond that, though.

Dion ​pointed out that WPorg_Handbook->admin_page_access_denied() is redirecting all denied requests to the handbook post type, which is also denied, causing the loop.

[coffee2code]

In 976:

Handbook plugin: remove admin redirect causing redirect loop for users with insufficient privileges. Fixes #725