Opened 9 years ago

Closed 5 years ago

#752 closed enhancement (invalid)

Theme trac: If reviewer has done more than 2 reviews automatically make them full reviewer

Reported by: karmatosed's profile karmatosed Owned by:
Milestone: Priority: normal
Component: Theme Review Keywords:


Currently we have the trainee role that manually has to be set to full review. This is a process that means we have to check each trainee. Sometimes we miss some. It would be great to automate this process.

Ideally this script would run once a week to catch any that could be bumped up to full reviewer. This would only be the role that allowed them to cc and assign to themselves. Nothing more than the step up from trainee reviewer.

Change History (7)

This ticket was mentioned in Slack in #themereview by karmatosed. View the logs.

9 years ago

This ticket was mentioned in Slack in #themereview by aknath707. View the logs.

9 years ago

#3 @nacin
9 years ago

There are 201 with permissions right now, and 283 who are the owner of >= 2 closed themes.

Everyone on the list appended to this comment would receive permissions immediately as a result of this.

Does this matter as much anymore now that a button can simply give them the next theme, and thus limits cherry-picking? Could we actually get rid of the "reviewer" role entirely and simply have a few more "trusted" folks who can cherry-pick?

#4 @karmatosed
9 years ago

I think any opening of the role would have to be talked about in the next team meeting. Personally, I'm not against it and it avoids a lot of confusion. The trainee role was there so we could also monitor people. If we have a report we can run to show those who have only done <2 reviews, we can achieve the same thing. I'll take it to the team in our next meeting as think that's the best plan.

#5 @nacin
9 years ago

  • Component changed from Trac to Theme Review

This ticket was mentioned in Slack in #themereview by rabmalin. View the logs.

8 years ago

#7 @tellyworth
5 years ago

  • Resolution set to invalid
  • Status changed from new to closed

It's a good idea but this has most likely been deprecated by changes to the theme review process. If it's still relevant then please re-open with fresh info.

Note: See TracTickets for help on using tickets.