Making WordPress.org

Opened 3 years ago

Last modified 3 days ago

#7554 accepted defect (bug)

CLPTEs can't bulk reject their waiting suggestions

Reported by: fxbenard Owned by: timse201
Priority: low Milestone:
Component: Translate Site & Plugins Keywords:
Cc:

Description

CLPTEs can't override already approved community translations.
At import all new similar strings are in "waiting" state. (Correct behavior)

2 options then:
Ask a locale member to review them or remove them to clean up the waiting list.

The issue is that CLPTEs can't bulk reject those waiting strings.
The bulk action isn't activated. Only one by one rejection is possible…

https://ibb.co/r56RfkK

Attachments (1)

SCR-20240404-kghz.png​ (141.5 KB ) - added by fxbenard 3 years ago.
Screenshot of the bulk action not working

Download all attachments as: .zip

Change History (5)

@fxbenard
3 years ago

Screenshot of the bulk action not working

#1 @timse201
3 days ago

#5659 was marked as a duplicate.

#2 @timse201
3 days ago

  • Owner set to timse201
  • Status new → accepted

#3 @timse201
3 days ago

I took a closer look at this. The bulk actions are handled by the public function bulk_post function in GlotPress.
In line 411, there is only a check for "can user approve". Please report it upstream. I think we want a secure function and some error messages when it fails. e.g. 10 rejected. 1 permission denied.
Once the implementation is complete, we can turn our attention to implementing it in the template.

Line 411:
​https://github.com/GlotPress/GlotPress/blob/a339c56f38eccac13c92379971bb403d6ad3a472/gp-includes/routes/translation.php#L411

Cases in line 421:
​https://github.com/GlotPress/GlotPress/blob/a339c56f38eccac13c92379971bb403d6ad3a472/gp-includes/routes/translation.php#L421

#4 @timse201
3 days ago

  • Priority normal → low
Note: See TracTickets for help on using tickets.