WordPress.org

Making WordPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#764 closed task (fixed)

Cannot translate the message for the case which result is multiple because it use string branch for plural form

Reported by: mayukojpn Owned by:
Milestone: Priority: normal
Component: Plugin Directory Keywords:
Cc:

Description

Could you fix the string for us to be able to translate?
it used at plugins/search.php:13 and plugins/topic-404.php:55

===Problem===
This branch isn't for the word of plural form. It's for the number of the result. But it makes branch with the function for plural form.

Japanese words don't have plural form. We cannot translate it with non-plural words setting.

http://blog.mayuko.me/wp-content/uploads/2014/12/plural-string.jpg

You can see this page https://translate.wordpress.org/projects/rosetta/forums/ja/default?filters[original_id]=149601

Change History (4)

#2 follow-up: @coffee2code
5 years ago

@SergeyBiryukov:

In your suggested solution in #665, should the singular string actually be "%s plugin found", or should it match the plural "Showing %s-%s of %s plugins"? The former seems better than seeing "Showing 1-1 of 1 plugins", but I don't what to presume what leads to the more appropriate translations.

#3 @iandunn
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

I committed [dotorg9228] to fix this before seeing Scott's message, and I assumed that using Showing %s-%s of %s plugins in the singular parameter was intentional. I'm happy to change it if we determine the other string would be better, though.

#4 in reply to: ↑ 2 @SergeyBiryukov
5 years ago

Replying to coffee2code:

In your suggested solution in #665, should the singular string actually be "%s plugin found", or should it match the plural "Showing %s-%s of %s plugins"?

"Showing %s-%s of %s plugins" in the singular string was intentional, as the condition above makes sure it's only displayed if $plugin_count > 1.

The point is to allow for this type of string in languages which use the single form for numbers greater than 1.

We could use "Showing %s-%s of %s plugin" if that makes more sense, but it doesn't really make a difference, since this form won't be displayed in English, and other languages would translate it according to their plural form rules.

I can't see what [dotorg9228] is, but if it's the same as in my comment, then I think we're good. Thanks Ian!

Note: See TracTickets for help on using tickets.