Making WordPress.org

Opened 2 years ago

Closed 13 months ago

Last modified 4 weeks ago

#7692 closed defect (bug) (fixed)

Missing Escaping, Strict Check, and PHPCS Issues in Multiple Files of jobs.wordpress.net

Reported by: deepakrohilla Owned by:
Priority: lowest Milestone:
Component: Jobs (jobs.wordpress.net) Keywords: has-patch
Cc:

Description

In multiple files strict check , escaping and alignment, phpcs issue found.
Needs to be fixed instances where data output lacks proper escaping especially in areas handling user-generated or dynamic content.

Attachments (3)

code1.PNG (28.0 KB ) - added by deepakrohilla 2 years ago.
alignment.PNG (20.8 KB ) - added by deepakrohilla 2 years ago.
d1.PNG (31.6 KB ) - added by deepakrohilla 2 years ago.

Download all attachments as: .zip

Change History (10)

@deepakrohilla
2 years ago

@deepakrohilla
2 years ago

This ticket was mentioned in PR #340 on WordPress/wordpress.org by @deepakrohilla.


2 years ago
#1

  • Keywords has-patch added; needs-patch removed

#2 @dd32
2 years ago

  • Priority highlowest

Strict checks are not always required, loose comparisons are often better in non-security scenarios. Marking as low-priority.

This ticket was mentioned in Slack in #meta by dufresnesteven. View the logs.


2 years ago

#4 @dd32
2 years ago

#7694 was marked as a duplicate.

This ticket was mentioned in PR #341 on WordPress/wordpress.org by @narenin.


2 years ago
#5

#6 @dd32
13 months ago

  • Resolutionfixed
  • Status assignedclosed

Closing due to inactivity and lack of severity.

@obenland commented on PR #340:


4 weeks ago
#7

There are a vast amount of code quality fixes that can be done across the meta repository. I'm not sure selected patches like this are the best way solve them. These should rather be updates as part of regular work or in a coordinated effort like it was done in Core.

Note: See TracTickets for help on using tickets.