Avoid creating new trac tickets unnecessarily

[obenland]

Sometimes the uploader creates a new trac ticket when it actually should append a new version to an existing ticket.

Example: ​https://wordpress.slack.com/archives/themereview/p1425779846001479

[obenland]

I'm not able to reproduce it. Will see if there's ever another report of this, but reopening a ticket is definitely no the cause.

[Otto42]

Once a ticket is closed, then the old sync process would not append to it anymore even if it was a reopened ticket. So, if this is still the case, then that's the same as it was previously.

[obenland]

Even reopened tickets pass the empty( $ticket[3]['resolution'] ) && 'approved' !== $ticket[3]['status'] condition though. Status is reopened and the resolution is empty.

[Otto42]

When a ticket is closed as not-approved, and the sync runs, then it will mark that version as "old" in the meta, correct? Well, that means it's not "new" anymore. So the uploader will fail this check:
'new' == $this->theme_post->_status[ $this->theme_post->max_version ] )

And create a new ticket. Won't matter that the ticket is re-opened, it will never get to that check because reopening the ticket doesn't make it new again.

[obenland]

r1382 and ​https://dotorg.trac.wordpress.org/changeset/9983 added the ability to handle ticket reopenings.
Someone would have to add an updated version in the max 15min between ticket reopening and sync script running to achieve that.