Changeset 8254 for sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support/page-update-php.php

Timestamp:

02/15/2019 03:54:03 AM (16 months ago)

Author:

dd32

Message:

Support: Move the update-php strings from the Helphub to the Support Theme for easier usage by locales.

This also switches the page template used from page.php to page-full-width.php on non-en_US sites to avoid some edgecases.

See #4139.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support/page-update-php.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support/page-update-php.php

@@ -9 +9 @@
 /*
 Use the default template for pages. This specific template is only used to indicate that the content needs to be
-manually injected, which happens in the HelpHub plugin.
+manually injected, which happens in `helphub-update-php-strings.php`
  */
-require get_stylesheet_directory() . '/page.php';
+if ( 'en_US' == get_locale() ) {
+    // Helphub will be active, so we need it's sidebar
+    require get_stylesheet_directory() . '/page.php';
+} else {
+    // Helphub may be active, but we're loading in a non-en_US locale so shouldn't display the EN sidebar
+    require get_stylesheet_directory() . '/page-full-width.php';
+}