Making WordPress.org

Opened 6 years ago

Closed 4 years ago

Last modified 4 years ago

#4139 closed task (blessed) (fixed)

Localized version of support/update-php needed outside of Helphub

Reported by: tobifjellner's profile tobifjellner Owned by:
Milestone: Priority: high
Component: HelpHub (wordpress.org/documentation) Keywords: close
Cc:

Description

When WP 5.1 is released (preliminary on Feb 21 2019) it will contain a check for PHP version on the server, and if the server's PHP version is below a set threshold value, a warning/recommendation will be shown in the Adminpanel.

This warning contains a (translatable and filterable) link to more information. Per default, it points to https://wordpress.org/support/update-php/ but of course we need to be able to offer a translated version of this page.

Formally speaking, such a translated version page is already possible: https://wordpress.org/support/update-php/ is a part of HelpHub and the strings for this page are included in the translation project https://translate.wordpress.org/projects/meta/forums

But HelpHub has not been launched yet outside of the global site in English. And everything else of HelpHub is not yet prepared for translation. And many locales that don't use the support forum would certainly not even be interested in translating the full scope of HelpHub just in order to be able to show the page with information about how to upgrade PHP.

Therefore: would it be possible to either migrate the translations of /upgrade-php/ to Rosetta or WordPress.org (keeping existing translations) or put it in a separate one-page project (like browsehappy).

It would be good if we could do this relatively soon, before RC of WordPress 5.1.

Change History (17)

#1 @SergeyBiryukov
6 years ago

  • Component changed from General to Support Hub

This ticket was mentioned in Slack in #meta by tobifjellner. View the logs.


6 years ago

#3 @Clorith
6 years ago

#4146 was marked as a duplicate.

This ticket was mentioned in Slack in #meta by tobifjellner. View the logs.


6 years ago

#5 follow-up: @dd32
6 years ago

Some options:

a) Move it to a Rosetta page, such as /about/update-php

  • Pro: Available to all sites
  • Pro: Translatable as part of the 'WordPress.org' project.
  • Con: It's not really an about page, it's a support doc.

b) Make https://wordpress.org/support/update-php/ accept a $locale parameter to display alternate translations. eg https://wordpress.org/support/update-php/?locale=de_DE

  • Pro: Should be easy to do, and we can redirect it elsewhere later if needed.
  • Con: Ran into a bug: #core46230
  • Con: It's not-great having random pages on wordpress.org being able to locale switch when we generally have translations on a separate domain
  • Con: Translations must be made within the forums translation project (can filter to strings in that file only though)

c) Make https://*.wordpress.org/support/update-php/always work, by loading the English Help Hub (with translations) if no locale Help Hub exists.

  • Pro: Easy to do, "just works" (ish). We already do this with Plugins/Theme Directories
  • Con: All the links away from the page will remain linking to English sites even if they have translated titles.
  • Con: A little complicated when the locale does have a Help Hub site, but it's just code
  • Con: Translations must be made within the forums translation project (can filter to strings in that file only though)
Last edited 6 years ago by dd32 (previous) (diff)

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.


6 years ago

#7 in reply to: ↑ 5 @SergeyBiryukov
6 years ago

Replying to dd32:

Some options

What about just moving the strings from the HelpHub plugin to the wporg-support page template, same as for various About pages in wporg-main theme?

That won't address the issues raised in #4146 for locales that don't have support forums, but it's better than what we have now, where translated content cannot be used at all.

For locales that don't have support forums, we can address this later when HelpHub is available on Rosetta sites.

Note: As a workaround, locales currently can create a page with an update-php slug, like https://ru.wordpress.org/support/update-php/, but it would be hard to make sure the content is regularly updated, so it's better to manage the strings in GlotPress.

#8 @dd32
6 years ago

In 8254:

Support: Move the update-php strings from the Helphub to the Support Theme for easier usage by locales.

This also switches the page template used from page.php to page-full-width.php on non-en_US sites to avoid some edgecases.

See #4139.

#9 @dd32
6 years ago

In 8255:

Support: Helphub TOC: Don't prepend the TOC if the post is being used for embeds. This fixes embeds being just the TOC (without spaces between items).

See #4139.

#10 @dd32
6 years ago

Okay, so I went with c from above:

c) Make https://*.wordpress.org/support/update-php/always work, by loading the English Help Hub (with translations) if no locale Help Hub exists.

Things worth noting:

  • Sites WITH a Locale forum, but no Helphub plugin do NOT get a TOC as that's part of Helphub. All links on the page go to locale-specific pages.
  • Sites WITHOUT a locale forum do have helphub enabled and get the TOC as a result. They have a Localised header, but everything between the header and footer (ie. Forum list, Documentation, etc) link to the English Forum site.
  • Non-en_US sites (Regardless of if there exist translations) do not get the Helphub sidebar.

If we want to add the TOC to non-locale-forum sites (like the German version above) or remove it entirely from not-english locales we can do that relatively easily, possibly by just unhooking the plugin from within the page-update-php.php page template.

Translations still exist in the wporg-forums project here, and can be found by filtering Meta -> Forums by the term helphub-update-php, for example in French

#11 follow-up: @dd32
6 years ago

Also, locale sites as far as I can tell, don't currently link to that page anywhere.

I'm not sure of the best way to surface the page, so if anyone can suggest a manner to link to it from https://de.wordpress.org/support/ without enabling all of Helphub..

#12 in reply to: ↑ 11 ; follow-up: @tobifjellner
6 years ago

Replying to dd32:

Also, locale sites as far as I can tell, don't currently link to that page anywhere.

I'm not sure of the best way to surface the page, so if anyone can suggest a manner to link to it from https://de.wordpress.org/support/ without enabling all of Helphub..

Hi,

Thanks for your great work.
Different locale teams have different situations, so they may find various ways to add a link. The most important link will anyway be from the "servehappy" functionality in core.
If there's a support forum, then one could, for instance, add a link from a "welcome" topic.

#13 in reply to: ↑ 12 @dd32
6 years ago

Replying to tobifjellner:

Different locale teams have different situations, so they may find various ways to add a link. The most important link will anyway be from the "servehappy" functionality in core.

That's my thought too, and why I didn't attempt to link to it.
If it makes sense for a locale to link to it, I'm sure they'll find a way, but for now it's mostly those visiting from wp-admin that matters

#14 @Clorith
5 years ago

  • Keywords close added

As mentioned, the Update PHP page is primarily surfaced via ServeHappy in wp-admin, so I think we can close this ticket out now that there's a solution in place to serve translated content for this page if the page doesn't explicitly exist.

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.


4 years ago

#16 @tellyworth
4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.


4 years ago

Note: See TracTickets for help on using tickets.