WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#1029 closed defect (invalid)

Update Parameters $protocols for /esc_url/ page

Reported by: emiluzelac Owned by:
Milestone: Priority: normal
Component: Developer Hub Keywords: reporter-feedback
Cc:

Description

We're missing few protocols in: https://core.trac.wordpress.org/browser/tags/4.2.2/src/wp-includes/formatting.php#L3096

'http', 'https', 'ftp', 'ftps', 'mailto', 'news', 'irc', 'gopher', 'nntp', 'feed', 'telnet', 'mms', 'rtsp', 'svn', 'tel', 'fax', 'xmpp'

This reflects: https://developer.wordpress.org/reference/functions/esc_url/


Reference:

Change History (2)

#1 @DrewAPicture
3 years ago

  • Resolution set to invalid
  • Status changed from new to closed

Hi Emil, thanks for the ticket.

This should really be a core trac ticket. That said, I think the best approach would be to document the default list in the DocBlock for wp_allowed_protocols() and then cross-reference that everywhere. Otherwise, we end up having to keep the list updated in multiple places, which can fall out of date.

Created #wp32421.

Last edited 3 years ago by DrewAPicture (previous) (diff)

#2 @emiluzelac
3 years ago

Perfect!

Note: See TracTickets for help on using tickets.