Better management of the emails trac sends

[sbressler]

Migrating from ​#wp17505:

Something relatively minor that's been bugging me for a long time: Commenting on a Trac issue or adding oneself to the CC list should not send an e-mail to that user, or at least not by default. Suppressing such e-mail for self-made changes is the default on other bug reporting systems (e.g. JIRA), and it would be great if we could make it the default for WP Trac as well.

Not just for CCs... We should have better management overall. There must be a trac plugin for this. And if there isn't, we should consider writing one.

[nacin]

In 225:

Trac: CSS and JS for notifications. see #127.

[nacin]

In 228:

Trac: Template changes for notifications. see #127.

[nacin]

In 229:

Trac: Trac core patch for WordPress fine-grained notifications. see #127.

[nacin]

In 230:

Trac/WP.org: Add a plugin that handles Trac notifications (as an endpoint and a management tool). see #127.

[nacin]

In 231:

Trac: This patch was made from the Trac 1.0.1 tag. see #127.

[nacin]

In 232:

Trac: Add schema for notifications tables. see #127.

[nacin]

In 233:

Trac: Add a tooltip to the notifications ticket star. see #127.

[nacin]

In 234:

Trac/WP.org: Display updates for the notifications subscription page. see #127.

[nacin]

In 236:

Trac: Remove blog-id-restricting code, it's not necessary. This plugin will be only activated on make/core anyway. see #127.

[nacin]

In 237:

Trac Notifications: Gravatars for ticket watchers. see #127.

[nacin]

In 241:

Trac: Change notifications conditional. see #127.

[nacin]

In 242:

Trac: Remove && which Genshi XML chokes on. see #127.

[nacin]

[243] fixes a bug in [229].

[nacin]

In 244:

Trac: Hide "Cc:" from ticket box when there are none. Note that on Core Trac, CCs are now disabled via the Black Magic trac plugin. see #127.

[nacin]

In 245:

Trac: Add JS that will hide the CC field from the query builder, to be called when notifications are enabled. see #127.

[nacin]

In 246:

Trac: Hide CC comments via JS, when notifications are enabled. see #127.

[nacin]

In 247:

Trac: Hide CCs when notifications are enabled. Executes JS added in [245], [246]. see #127.

[nacin]

In 249:

Trac Notifications plugin: Remove the (false) claim that you receive notifications once you have commented. (I think we should consider adding this, though, now that you can unsubscribe/block.) see #127.

[nacin]

Hello! You might have been linked here from the post announcing this feature. Here's a rundown for how this works:

• The Trac's site.html template, when viewing a ticket, does an Ajax request to make.wordpress.org/core.
• make/core has a WordPress plugin that queries the tables in the Trac database (thanks to #253). HTML for the notifications box is returned.
• wpTrac.notifications.init is run (code in the JS we include on Trac), which renders the notifications box and ticket star, and binds the appropriate events.
• When an action is taken, an Ajax request is made to make.wordpress.org/core to save it.
• Component/milestone subscriptions are handled by a page on make/core (currently a shortcode), which saves to the tables in the Trac DB. This isn't launched yet, though.
• We patched Trac core directly to then query our custom subscriptions tables whenever a ticket is updated. Ideally, this later becomes a single-line patch to add an extension point (hook) and then a Trac plugin, rather than maintaining this, though it's not that bad.

[nacin]

This was built to work on other Tracs. As explained on ​make/core, a lot of features are currently coupled into the WP.org design, and that's also the case here for the moment. It also requires the Trac to be migrated to MySQL (#253), for WP.org cookies to be used and for SSL to be forced (so make.wordpress.org and the Trac install always agree on the logged-in status), and for email addresses to be synced from WP.org to Trac (#170). Basically, the last round of improvements included a lot of groundwork for this.

At the moment, no other Tracs are migrated to MySQL, but I can start bringing all of this functionality to other Tracs next week.

[nacin]

In 254:

Trac: Use a dashicon for 'Stars' columns on reports. Right-align the Comments and Stars columns and make them as narrow as possible. see #127, I guess.

[nacin]

In 259:

Trac: JS and CSS for report notification stars. see #127.

[nacin]

In 260:

Trac: Template updates to go with [259]. see #127.

[nacin]

In 262:

Trac: Pass the authenticated status to the notifications JS. see #127.

[nacin]

In 263:

Trac: Only initialize notifications (beyond CC field hiding) if the user is authenticated. Ideally: non-authenticated users can see stars and are asked to log in when they click. see #127.

[nacin]

In 264:

Trac: Restrict Dashicons sizes, which were recently bumped from 16px to 20px in core. see #127, ​#WP26518.

[nacin]

In 265:

Trac Notifications: Set height/width for Gravatars so they load into a grid. see #127.

[nacin]

In 289:

Trac Notifications: Add conditional support for remaining Tracs. see #127.

[nacin]

In 371:

Update Trac patch to handle focus-based subscribers and new ticket subscribers. see #127, #287, #300.

[nacin]

In 373:

Trac Notifications: Updates to the preferences form for focuses, new tickets, and subcomponents. see #127, #287, #300.