WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 21 months ago

#1323 closed defect (fixed)

Browse Happy banner shows up when App users open their Admin view using a Webview from the official apps (Android or IOS)

Reported by: mbiais Owned by:
Milestone: Priority: normal
Component: Browse Happy Keywords:
Cc:

Description

That would be great if we could whitelist User Agent used by the apps.

Here are a sample of the an Android UA:
wp-android/2.6.4 (Android 4.3; en_US; samsung GT-I9505/jfltezh)
wp-iphone/4.6.1 (iPhone OS 8.1.2, iPhone) Mobile

References:

Reference to the issue opened on the WPAndroid bug tracker: https://github.com/wordpress-mobile/WordPress-Android/issues/3308

https://cloud.githubusercontent.com/assets/1238696/10321442/84430242-6c2d-11e5-8b60-2212ea2e6144.png

Change History (5)

#2 @dd32
4 years ago

I'm unable to duplicate this on an Android, and the user agents provided don't trigger Browse Happy.

Android: https://api.wordpress.org/core/browse-happy/1.1/?useragent=wp-android/2.6.4%20(Android%204.3;%20en_US;%20samsung%20GT-I9505/jfltezh)
iOS: https://api.wordpress.org/core/browse-happy/1.1/?useragent=wp-iphone/4.6.1%20(iPhone%20OS%208.1.2,%20iPhone)%20Mobile

Both the update & insecure flags are false, and there's nothing in the UA to identify it as Chrome..

#3 @dd32
4 years ago

Sent that a little early..
The Browser within the Android app doesn't use the wp-android/ user-agent, on my device it uses this:

Mozilla/5.0 (Linux; Android 6.0; Nexus 5 Build/MRA58K; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/45.0.2454.95 Mobile Safari/537.36

which is detected as Mobile Safari

Can you post the user agents in question for the Nexus 7? I have a feeling that it really is an outdated version that needs updating.

#4 @coffee2code
21 months ago

In 5954:

Browse Happy API: Add unit test item for Android-based user-agent sent by mobile app.

See #1323.

#5 @coffee2code
21 months ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [5952]. Added a unit test case for this in [5954].

Note: See TracTickets for help on using tickets.