Making WordPress.org

Opened 3 years ago

Closed 21 months ago

Last modified 21 months ago

#1971 closed defect (fixed)

Forums: Incorrect number of replies in Topic Info

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: Priority: normal
Component: Support Forums Keywords:


In this topic, the first reply was erroneously trashed at some point.

Clicking Edit and changing Reply Status from Trash to Publish didn't help (nothing changed), so the workaround was to click Unapprove and then Approve.

After that, the reply is displayed as expected, but the sidebar shows wrong info:

0 replies (+ 1 hidden)

The content area shows correct info:

Viewing 2 replies - 1 through 2 (of 2 total)

See the screenshot.

Attachments (1)

meta-1971.PNG (82.6 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (11)

This ticket was mentioned in Slack in #forums by sergey. View the logs.

3 years ago

#2 @netweb
2 years ago

Related: #2043

This ticket was mentioned in Slack in #forums by sergey. View the logs.

2 years ago

#4 @SergeyBiryukov
22 months ago

In 5674:

Support Forums: Pass correct number of arguments to Dropin::bbp_update_topic() and Dropin::bbp_update_reply().

See #1971, #2043.

#5 @SergeyBiryukov
21 months ago

In 5675:

Support Forums: Update the necessary meta data when editing a topic created before 2017-07-17, as those topics can have potentially inaccurate data.

See #1971, #2043.

#6 @SergeyBiryukov
21 months ago

  • Resolution set to fixed
  • Status changed from new to closed

#7 @SergeyBiryukov
21 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Can still reproduce the issue mentioned in comment:13:ticket:2043:

Triggered the incorrect replies counts issue recently a couple of times:

  1. Reply to a topic that had no replies, it has 1 reply now.
  2. Edit your reply to fix a typo or something.
  3. Akismet didn't flag the initial post, but flags the edited one for some reason, without updating the replies count.
  4. Once you unspam the post, the topic has 2 replies (+ -1 hidden).

#8 @SergeyBiryukov
21 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from reopened to closed

In 5686:

Support Forums: Update topic replies count if the reply status changes on editing.

This is neccesary to properly account for the status change as a result of Akismet check or user flagging rather than an explicit moderator action.

Fixes #1971.

#9 @SergeyBiryukov
21 months ago

In 5689:

Support Forums: Add bbPress ticket reference to Hooks::update_replies_count_on_editing_reply().

See #1971, #bbpress3132.

#10 @SergeyBiryukov
21 months ago

In 5710:

Support Forums: Don't update reply counts when arching or unarchiving a pending or spam post, as the number of hidden replies does not change in that case.

See #1971, #2171.

Note: See TracTickets for help on using tickets.