Forums: "+X hidden" link should appear if the topic has archived posts

[SergeyBiryukov]

With the introduction of the "Archived" status, there's no way to know if the current topic has any archived posts, unless you add ?view=all to the URL manually.

Related: #1984, #2043.

[netweb]

Thanks for the patch @denisco though I don't see how 2171.patch​ addresses the issue of this ticket, it's bumping the topic reply hidden count when archiving and unarchiving a topic, nothing to do with ?view=all, maybe this patch was meant for a different ticket?

[SergeyBiryukov]

Renaming the ticket for clarity.

[denisco]

@netweb ?view=all link shows when topic has hidden replies. Archiving and unarchiving functions not bumping topic reply hidden count. I fixed it in this patch.

[SergeyBiryukov]

2171.patch​ looks good, just needs a bbp_is_reply() check before bumping the count.

The patch doesn't fix the hidden replies count for existing topics, but solves the issue for new topics going forward. Existing topics could be fixed at some point later with a custom recount script.

[SergeyBiryukov]

In 5088:

Support Forums: When archiving or unarchiving a reply, reflect the change in the topic's hidden replies count.

Props denisco.
Fixes #2171.

[SergeyBiryukov]

In 5710:

Support Forums: Don't update reply counts when arching or unarchiving a pending or spam post, as the number of hidden replies does not change in that case.

See #1971, #2171.