Making WordPress.org

Opened 21 months ago

Closed 17 months ago

Last modified 12 months ago

#2171 closed defect (fixed)

Forums: "+X hidden" link should appear if the topic has archived posts

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: Priority: normal
Component: Support Forums Keywords: has-patch


With the introduction of the "Archived" status, there's no way to know if the current topic has any archived posts, unless you add ?view=all to the URL manually.

Related: #1984, #2043.

Attachments (1)

2171.patch (1.2 KB) - added by denisco 17 months ago.

Download all attachments as: .zip

Change History (8)

17 months ago

#1 @denisco
17 months ago

  • Keywords has-patch added

#2 @netweb
17 months ago

Thanks for the patch @denisco though I don't see how 2171.patch addresses the issue of this ticket, it's bumping the topic reply hidden count when archiving and unarchiving a topic, nothing to do with ?view=all, maybe this patch was meant for a different ticket?

#3 @SergeyBiryukov
17 months ago

  • Summary changed from Forums: "+X hidden" link should include archived posts to Forums: "+X hidden" link should appear if the topic has archived posts

Renaming the ticket for clarity.

#4 @denisco
17 months ago

@netweb ?view=all link shows when topic has hidden replies. Archiving and unarchiving functions not bumping topic reply hidden count. I fixed it in this patch.

#5 @SergeyBiryukov
17 months ago

2171.patch looks good, just needs a bbp_is_reply() check before bumping the count.

The patch doesn't fix the hidden replies count for existing topics, but solves the issue for new topics going forward. Existing topics could be fixed at some point later with a custom recount script.

#6 @SergeyBiryukov
17 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 5088:

Support Forums: When archiving or unarchiving a reply, reflect the change in the topic's hidden replies count.

Props denisco.
Fixes #2171.

#7 @SergeyBiryukov
12 months ago

In 5710:

Support Forums: Don't update reply counts when arching or unarchiving a pending or spam post, as the number of hidden replies does not change in that case.

See #1971, #2171.

Note: See TracTickets for help on using tickets.