Forums: Moderators should have a way to edit user profiles

[SergeyBiryukov]

After the upgrade to bbPress 2.x, there's no longer a way for keymasters and moderators to edit other users' profiles.

Some real-life use cases:

• Give user a custom title (after #1950).
• Hide inappropriate Gravatars (#2401).
• Help a user who cannot receive the password reset email. Could be a number of reasons:
  • Agressive spam filtering
  • A typo in the address
  • Expired domain
  • etc.

• Block or unblock user by changing their bbPress role (#1989)
• Block a spam bot by changing the email and/or password.

[SergeyBiryukov]

In 5631:

Support Forums: Allow keymasters and moderators to edit users without having an Administrator role on the site.

Fixes #1985.

[Otto42]

What does this actually change, visually, so I know what to examine in testing?

[SergeyBiryukov]

Replying to Otto42:

What does this actually change, visually, so I know what to examine in testing?

If you log in as someone who is a moderator or keymaster without an Administrator role on the site, there should be a working Edit link in the sidebar on other users' profiles.

[SergeyBiryukov]

Replying to SergeyBiryukov:

Help a user who cannot receive the password reset email.

Note: [5631] doesn't cover this, as bbPress currently does not allow for changing a user's email address without a confirmation, see ​bbp_edit_user_handler(). But that happens rarely enough and could be addressed later if needed, maybe in #2401.

[ocean90]

Keymasters and especially moderators shouldn't be able to edit admins and super admins if they don't have the same role.

[SergeyBiryukov]

In 5632:

Support Forums: Disallow moderators and keymasters to edit admins and super admins, unless they have the same role.

See #1985.

[SergeyBiryukov]

Replying to SergeyBiryukov:

Help a user who cannot receive the password reset email.

Note: [5631] doesn't cover this, as bbPress currently does not allow for changing a user's email address without a confirmation, see ​bbp_edit_user_handler().

Per a ​brief Slack discussion, email editing should be addressed as well, as the team currently uses the old bbPress 1.x profile pages for that. Keeping the ticket open for now.

[SergeyBiryukov]

In 5633:

Support Forums: Allow keymasters and moderators to change user's email address without requiring a confirmation.

Fixes #1985.