WordPress.org

Making WordPress.org

Opened 2 years ago

Closed 2 years ago

Last modified 22 months ago

#2398 closed defect (fixed)

Support Theme: List of inline topic actions is too long when translated

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: Priority: normal
Component: Support Forums Keywords: has-patch has-screenshots
Cc:

Description

Inline topic actions can become longer when translated, and the list wraps to a second line and overlaps with some of the content, see the screenshot.

One option is to remove "Stick (to all forums)" action from that list, as it's used much less frequently than others. It would also improve #1996 further.

The action would still be available via the "Topic Admin" menu in the sidebar, it just doesn't have to be an inline action.

Attachments (4)

meta-2398.PNG (11.8 KB) - added by SergeyBiryukov 2 years ago.
meta-2398.2.PNG (16.7 KB) - added by SergeyBiryukov 2 years ago.
meta-2398.patch (1.8 KB) - added by SergeyBiryukov 2 years ago.
meta-2398.3.PNG (31.8 KB) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (19)

#1 @netweb
2 years ago

A quick in-browser mockup of swapping admin-link texts to dashicons:

Moderator view:

  • https://cldup.com/cDCaPH_vf6.png

User View:

  • https://cldup.com/bdH5apQnEI.png

bbPress 2.6 with Twenty Seventeen:

  • https://cldup.com/9JM009gfjc.png
  • https://cldup.com/A3AP4Zt581.png
Approve/Unapprove
Archive dashicons-archive
Close/Open dashicons-lock
Delete
Edit dashicons-edit
Merge dashicons-editor-contract
Move dashicons-move
Reply dashicons-admin-comments
Spam/Unspam dashicons-flag
Split dashicons-editor-expand
Stick dashicons-sticky
Stick to front dashicons-megaphone
Trash/Untrash dashicons-trash

#2 @samuelsidler
2 years ago

Generally speaking, I like icons for actions. But I think in these instances, there are too many which make them too ambiguous.

#3 follow-up: @SergeyBiryukov
2 years ago

Added a better screenshot.

  • meta-2398.PNG may not look pretty, but doesn't display any issues otherwise.
  • meta-2398.2.PNG illustrates an actual issue where a link is hidden behind the actions, and it's easy to accidentally click one of them instead of the link.

I like the direction of swapping the links with dashicons, but yeah, some of them seem ambiguous at the first glance, specifically Merge, Move, or Split.

#4 in reply to: ↑ 3 @netweb
2 years ago

Replying to samuelsidler:

Generally speaking, I like icons for actions. But I think in these instances, there are too many which make them too ambiguous.

Replying to SergeyBiryukov:

I like the direction of swapping the links with dashicons, but yeah, some of them seem ambiguous at the first glance, specifically Merge, Move, or Split.

Yes, I agree, I'm not a fan of the mock up myself either, so a few thoughts, thinking out loud:

  • For a standard user, they've only got a couple of icons, though in this case why not continue to include the text with the dashicon and hide if its required for small screens
  • For moderators there are 8 dashicons there, for topics, these actions are also displayed in the sidebar, adding the dashicons to prefix each of these in the sidebar could work as a "key" or sorts
  • Designing some more intuitive icons for these actions could be beneficial, it was quick and easy to mock this up as dashicons was already being used so that's what I did, researching font awesome, github octicons etc

#5 follow-ups: @SergeyBiryukov
2 years ago

One option is to remove "Stick (to all forums)" action from that list

I've found at least three mentions in the last couple months that showing Stick/Unstick options on hover is not intuitive for plugin authors, and these actions should be moved to Topic Admin sidebar:
https://wordpress.slack.com/archives/forums/p1478880656001737
https://wordpress.slack.com/archives/forums/p1480417813004334
https://wordpress.slack.com/archives/forums/p1485104789009310

On a related note, I don't see a purpose for "Reply" action there either, as WordPress.org forums don't use threads, and that link just redirects to the same reply form without any visual difference.

#6 in reply to: ↑ 5 ; follow-up: @netweb
2 years ago

Replying to SergeyBiryukov:

On a related note, I don't see a purpose for "Reply" action there either, as WordPress.org forums don't use threads, and that link just redirects to the same reply form without any visual difference.

On topics with lots of replies it does also work as an anchor shortcut to the reply form without having to scroll all the wy to the bottom of the page...

I've no strong opinion on keeping, just wanted to point out the above, I think some more mock ups are in order here

I'm not where we'd go looking for more ideas for new icons that'd better reflect some of the actions we use also /shrug

#7 in reply to: ↑ 6 ; follow-up: @SergeyBiryukov
2 years ago

Replying to netweb:

On topics with lots of replies it does also work as an anchor shortcut to the reply form without having to scroll all the wy to the bottom of the page...

#1977 introduced a "Reply to Topic" link in the sidebar for that. I was referring to the one that shows on hover in the first post of a topic.

#8 in reply to: ↑ 7 @netweb
2 years ago

Replying to SergeyBiryukov:

Replying to netweb:

On topics with lots of replies it does also work as an anchor shortcut to the reply form without having to scroll all the wy to the bottom of the page...

#1977 introduced a "Reply to Topic" link in the sidebar for that. I was referring to the one that shows on hover in the first post of a topic.

Thanks :thumbs up:

#9 @samuelsidler
2 years ago

I think we need a new UX solution here (cc @mapk). Icons aren't great – for reasons mentioned above – but text isn't great in its current form either. It'd be good to get a full list of all moderator/admin links that are required, which are not necessarily the ones that are there now (as mentioned above). With that, we can start to think through a new UX that will scale better for translations and hopefully work better for moderators / plugin authors / everyone(!).

#10 in reply to: ↑ 5 @SergeyBiryukov
2 years ago

Replying to SergeyBiryukov:

I've found at least three mentions in the last couple months that showing Stick/Unstick options on hover is not intuitive for plugin authors, and these actions should be moved to Topic Admin sidebar

Moved to a separate ticket: #2519.

#11 follow-up: @SergeyBiryukov
2 years ago

  • Keywords has-patch has-screenshots added

Going to go with meta-2398.patch, which keeps the essential actions (Edit, Close, Spam, Unapprove, Archive) as inline quick links: meta-2398.3.PNG, and moves the rest (Merge, Stick) to the Topic Admin sidebar section. Reply link is removed completely, as it's redundant since #1977 introduced a sidebar link for the same purpose.

Seems to be the most logical solution here: it reduces visual clutter, works better for translations, and doesn't require a new UX solution for now.

#12 in reply to: ↑ 11 ; follow-ups: @SergeyBiryukov
2 years ago

Replying to SergeyBiryukov:

Going to go with meta-2398.patch, which keeps the essential actions (Edit, Close, Spam, Unapprove, Archive) as inline quick links

Unapprove probably shouldn't be there either, as "bad" topics are generally either archived or marked as spam, not pushed back to Pending queue. But let's keep it for this iteration and remove later if needed.

#13 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 4974:

Support Forums: Reduce the list of inline topic admin links to Edit, Close, Spam, Unapprove, Archive:

  • This helps to avoid visual clutter and provide enough room for translations.
  • Less commonly used actions (Merge, Stick) are still available via "Topic Admin" sidebar section.
  • Reply link is removed completely, as it's redundant since [4720] introduced a sidebar link for the same purpose.

Fixes #2398.

#14 in reply to: ↑ 12 @netweb
2 years ago

Replying to SergeyBiryukov:

Unapprove probably shouldn't be there either, as "bad" topics are generally either archived or marked as spam, not pushed back to Pending queue. But let's keep it for this iteration and remove later if needed.

bbPress has been discussing the removal of "Unapprove" entirely, it remains undecided and is an ongoing conversation

The most recent conversation and links to previous conversations in #bbPress on Slack are here.

#15 in reply to: ↑ 12 @SergeyBiryukov
22 months ago

Replying to SergeyBiryukov:

Unapprove probably shouldn't be there either, as "bad" topics are generally either archived or marked as spam, not pushed back to Pending queue. But let's keep it for this iteration and remove later if needed.

Follow-up: #2936

Note: See TracTickets for help on using tickets.