WordPress.org

Making WordPress.org

Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#2694 closed defect (fixed)

Plugin Directory: Use _n() for "translated into these locales" string

Reported by: SergeyBiryukov Owned by: ocean90
Milestone: Plugin Directory v3.0 Priority: normal
Component: Plugin Directory Keywords: has-patch commit
Cc:

Description

'%1$s has been translated into these %2$d locales: %3$s.' needs _n() to be translated properly.

Additionally, the 1 === count( $locales ) case should be checked separately, see the note in Codex.

Attachments (1)

2694.patch (1.7 KB) - added by SergeyBiryukov 8 months ago.

Download all attachments as: .zip

Change History (4)

#1 @ocean90
8 months ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 5372:

Plugin Directory: Use _n() for "translated into these locales" string.

Props SergeyBiryukov.
Fixes #2694.

#2 follow-up: @Presskopp
8 months ago

Am I right that the first line (singular) is just a 'placeholder' and never used? Translating it, it confuses me, because these %2$d locales is not singular. Can this be clarified more?

'%1$s has been translated into these %2$d locales: %3$s.',
'%1$s has been translated into these %2$d locales: %3$s.',
Last edited 8 months ago by Presskopp (previous) (diff)

#3 in reply to: ↑ 2 @SergeyBiryukov
8 months ago

Replying to Presskopp:

Am I right that the first line (singular) is just a 'placeholder' and never used?

It would be used in languages where the singular form is used not just for 1 item, but also for 21, 31 items, etc. (Russian and some others).

In English or German it won't be used, just translate it to whatever makes the most sense :)

Note: See TracTickets for help on using tickets.