Making WordPress.org

Opened 7 years ago

Closed 7 years ago

#3027 closed defect (bug) (fixed)

Events API: Two meetups returned for same date in same city

Reported by: dd32's profile dd32 Owned by:
Milestone: Priority: normal
Component: API Keywords: needs-patch good-first-bug
Cc:

Description

The Adelaide meetup group is seeing some odd results in the events API:

http://api.wordpress.org/events/1.0/?location=Adelaide,%20SA
https://www.dropbox.com/s/sdvqegjdm7lb6tq/Screenshot%202017-08-07%2011.42.30.png?dl=0

They use a monthly-repeating meetup, entitled WordPress Adelaide Monthly Meetup, and then edit the title to be WordPress Adelaide August Meetup.

Looking in the database, theres two source_id's: zdxnhlywlblb & hfllbnywlblb - it looks like when they edit the meetup out of the series it creates a new meetup, and the WordPress.org ingester fails to realise it already had that in the DB (because the source_id changed, but the URL stayed the same)

Looking at the database, it looks like this has happened in a few other locations as well. Perhaps we should consider keying it unique by type, url in addition to type, source_id.

Attachments (2)

Screenshot 2017-08-07 11.42.30.png (206.1 KB) - added by dd32 7 years ago.
events-api-adelaide.json (1.5 KB) - added by dd32 7 years ago.

Download all attachments as: .zip

Change History (13)

#1 @ocean90
7 years ago

Related: #2720

#2 @iandunn
7 years ago

  • Keywords needs-patch good-first-bug added

Also reported in #wp41935.

This ticket was mentioned in Slack in #meta by iandunn. View the logs.


7 years ago

#4 @iandunn
7 years ago

Related #3321

#5 @iandunn
7 years ago

The changing IDs might be a bug in Meetup's API (hat tip to @casiepa for finding that).

This ticket was mentioned in Slack in #meta-wordcamp by iandunn. View the logs.


7 years ago

#7 @iandunn
7 years ago

This is closely related to #2720 and #3321, so I think we should take those into account when considering solutions. There may be an elegant solution which solves all of those cases; whereas coming up with 3 independent solutions could get messy.

This ticket was mentioned in Slack in #meta-wordcamp by coreymckrill. View the logs.


7 years ago

This ticket was mentioned in Slack in #meta by sippis. View the logs.


7 years ago

This ticket was mentioned in Slack in #meta-wordcamp by miss_jwo. View the logs.


7 years ago

#11 @iandunn
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Adding a new unique key for the type and url fields worked.

Props dd32.

Note: See TracTickets for help on using tickets.