Add notification about combaining reimbursement requests

[sippis]

In WordCamp organizers handbook it states that

... we urge all organizing teams to submit one reimbursement request per out-of pocket purchaser.

This can easily forgotten or not even noticed if team member has not read handbook deeply. We could and should show friendly notice about this always when organizer is on dashboard page which is related to reimbursements.

Easiest way to achieve this is check 'wcb_reimbursement' === $GETpost_type? which applies on reimbursements listing and creating new one. Edit view already has reminder about this on "Payment Information" meta box, but it does not hurt to state it bigger when creating new, does it?

I'll make patch in few days.

[sippis]

3286.diff contains patch for this. Notice is displayed when viewing listing of reimbursement requests or creating new. Message is same as in "Payment Information" meta box, notice level is warning.

[sippis]

In WC bug scrub today we discussed this ticket a little.

Ian was hesitant to make it a notice, since it's not an urgent thing, and I worry that over-using them leads to notice-fatigue, where people just stop looking at them at all. It'd definitely be good to have a note on the page, though, at the very least. But maybe not with the notice colors/etc.

Corey suggested that notice could be info instead of warning and that we should also add is-dismissable. Maybe also a small piece of javascript to have it remember the user setting and not show it again.

I also started to think, that the notice should be shown only when submitting a new reimbursement request. Not in reimbursement request list.

How much we get reimbursement requests that are not combined as we ask? How much pain does it cause? Would this notice fill some real-life need?

[dd32]

This ticket has been moved to GitHub ​https://github.com/WordPress/wordcamp.org/issues/658