Making WordPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 10 months ago

#409 closed defect (bug) (fixed)

Embedded Vimeo videos are blocked over SSL

Reported by: mauryaratan's profile mauryaratan Owned by:
Milestone: Priority: normal
Component: SSL Keywords: has-patch
Cc:

Description

All embedded videos aren't displayed anymore since WordPress.org is switched to SSL. Even when we use [vimeo https://vimeo.com/VIDEO_ID].

Issue can be verified here - https://wordpress.org/plugins/stag-custom-sidebars/

Change History (2)

#1 @Otto42
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Updated the code to use protocol relative URLs here.

This ticket was mentioned in PR #410 on WordPress/wporg-mu-plugins by @ryelle.


10 months ago
#2

  • Keywords has-patch added

Fixes #409 — When the page was loaded initially, the isSidebarWithinViewport check was run on the collapsed sidebar, so the height check in isSidebarWithinViewport passed and the sidebar is set as fixed. Then, a few lines later, the collapse/expand toggle logic expanded the sidebar on large screens, and now it could be too tall for the fixed sidebar behavior.

This fix just swaps the initial isSidebarWithinViewport to after the toggle button logic, so that the menu is in it's correct state when the height is measured.

To test:

Note: See TracTickets for help on using tickets.