#409 closed defect (bug) (fixed)
Embedded Vimeo videos are blocked over SSL
Reported by: | mauryaratan | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | SSL | Keywords: | has-patch |
Cc: |
Description
All embedded videos aren't displayed anymore since WordPress.org is switched to SSL. Even when we use [vimeo https://vimeo.com/VIDEO_ID]
.
Issue can be verified here - https://wordpress.org/plugins/stag-custom-sidebars/
Change History (2)
This ticket was mentioned in PR #410 on WordPress/wporg-mu-plugins by @ryelle.
16 months ago
#2
- Keywords has-patch added
Fixes #409 — When the page was loaded initially, the isSidebarWithinViewport
check was run on the collapsed sidebar, so the height check in isSidebarWithinViewport
passed and the sidebar is set as fixed. Then, a few lines later, the collapse/expand toggle logic expanded the sidebar on large screens, and now it could be too tall for the fixed sidebar behavior.
This fix just swaps the initial isSidebarWithinViewport
to after the toggle button logic, so that the menu is in it's correct state when the height is measured.
To test:
- Use the documentation test site
- View a few articles with different ToC lengths, for example http://localhost:8888/article/roles-and-capabilities/, http://localhost:8888/article/before-you-create-a-network/
- Try at different screen sizes
Updated the code to use protocol relative URLs here.