WordPress.org

Making WordPress.org

Opened 6 years ago

Closed 6 years ago

#465 closed defect (fixed)

Login button on GlotPress login page has incorrect styling

Reported by: mbootsman Owned by: samuelsidler
Milestone: Priority: normal
Component: Translate Site & Plugins Keywords: has-patch
Cc:

Description

The login button on the GlotPress login button is not styled correctly.
URL of the page: http://translate.wordpress.org/login

The button ID selector has an incorrect font-size and margin.

Attachments (1)

465.patch (281 bytes) - added by mbootsman 6 years ago.
Added CSS styles for button id element

Download all attachments as: .zip

Change History (7)

@mbootsman
6 years ago

Added CSS styles for button id element

#1 @mbootsman
6 years ago

  • Keywords has-patch added; needs-patch removed

#2 @samuelsidler
6 years ago

The patch is fine. Any reason not to fix this in GlotPress-proper (e.g., here)?

#3 @mbootsman
6 years ago

Can't think of any ;-)
Will submit a patch on svn.glotpress.org

Patch submitted here

#4 @samuelsidler
6 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

Reopen this ticket if GlotPress decides not to take the upstream patch and we'll land it in our theme.

#5 @mbootsman
6 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

Marko decided not to include the font-size rule. So, this will be the place to fix it :)
See Marko's commment: https://glotpress.trac.wordpress.org/ticket/326#comment:1

#6 @samuelsidler
6 years ago

  • Owner set to samuelsidler
  • Resolution set to fixed
  • Status changed from reopened to closed

In 607:

GlotPress theme: Fix styling of login button. Fixes #465. props mbootsman

Note: See TracTickets for help on using tickets.