Making WordPress.org

Opened 4 years ago

Last modified 23 months ago

#5383 new task (blessed)

Trac: Merge "Text Changes" component with the "ui-copy" focus

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by:
Milestone: Priority: normal
Component: Trac Keywords:
Cc:

Description (last modified by SergeyBiryukov)

Background: #4610, #4850.

The ui-copy focus was added to Trac in [9076]. Apparently the name is not clear enough for non-native English speakers and causes some confusion: #WP51080 is just a recent example, but there were some earlier examples too.

There is also a "Text Changes" component that is no longer actively used and can be retired in favor of the focus, per comment:2:ticket:4850, as text changes can belong to a particular component or span across multiple components.

Based on the above, I think the following would make sense:

  • Rename the ui-copy focus to text-changes to clarify its purpose.
  • Remove the "Text Changes" component in favor of the focus.

Change History (4)

#1 @SergeyBiryukov
4 years ago

  • Description modified (diff)

#2 @garrett-eclipse
4 years ago

Thanks @SergeyBiryukov I concur, even as an english speaker it took me a while to realize ui-copy wasn't a focus on copy-paste actions in the UI.

#3 @sabernhardt
23 months ago

The "Text Changes" component is cleared of open tickets (moving #WP50785, #WP55368 and #WP55546 to Administration or General).

#4 @dd32
23 months ago

Rename the ui-copy focus to text-changes to clarify its purpose.

Unfortunately focuses are actually a text-field, not a category, and so renaming is not exactly possible.

We can delete the ui-copy focus, and add a new text-changes focus, but that won't migrate the existing tickets. Additionally, it's not possibly to bulk-edit tickets from the Trac UI to change the focus field, without a systems request to run a find-replace on the field.

Instead of a systems request, We might be able to add a method to our custom Trac WP-API, which will allow running a SQL against the Trac DB to do that find-replace.

Remove the "Text Changes" component in favor of the focus.

I'm not sure how Trac handles deleted components for existing tickets that are already closed on the component, I'd want to verify what happens there first before actioning this. I suspect it's fine and it'll continue to show the old component, just make it harder to query for them retroactively.

Note: See TracTickets for help on using tickets.