WordPress.org

Making WordPress.org

Opened 12 months ago

Closed 12 months ago

Last modified 7 months ago

#5489 closed defect (fixed)

<code> Element Very Low Contrast

Reported by: davidbaumwald Owned by: coffee2code
Milestone: Priority: normal
Component: Handbooks Keywords: has-screenshots
Cc:

Description

Some time recently, the color of the <code> elements changed, and there's very little contrast with the background. The color is set to #f8f8f2. Screenshots incoming of the PHP Coding Standards page. Definitely not a page-specific issue, as I have seen it on that page, and https://make.wordpress.org/core/handbook/best-practices/commit-messages/

Attachments (2)

Screenshot 2020-10-27 192313.jpg (58.6 KB) - added by davidbaumwald 12 months ago.
Low contrast of <code> elements
Screenshot 2020-10-27 192439.jpg (26.9 KB) - added by davidbaumwald 12 months ago.
Responsible CSS

Download all attachments as: .zip

Change History (9)

@davidbaumwald
12 months ago

Low contrast of <code> elements

@davidbaumwald
12 months ago

Responsible CSS

#1 @joyously
12 months ago

It appears to be from the code syntax block CSS. The plain <code> elements are black.

#2 follow-up: @davidbaumwald
12 months ago

#5490 was marked as a duplicate.

#3 in reply to: ↑ 2 @juanbernal98
12 months ago

Replying to davidbaumwald:

#5490 was marked as a duplicate.

Sorry! Didn't see that, good job!

#4 @coffee2code
12 months ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 10415:

Breathe: Override default Code Syntax Block plugin syntax highlighting theme to use the one included in theme.

Props davidbaumwald, joyously, juanbernal98, coffee2code.
Fixes #5489.

#5 @coffee2code
12 months ago

In 10416:

Breathe: Add additional styles for code blocks.

See #5489.

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


7 months ago

#7 @paaljoachim
7 months ago

I believe this Learn issue might be related:
https://github.com/WordPress/learn/issues/207

Note: See TracTickets for help on using tickets.