WordPress.org

Making WordPress.org

Opened 7 months ago

Last modified 7 months ago

#5621 new defect

Don't warn on numbered placeholders <=> non-numbered placeholders

Reported by: dd32 Owned by:
Milestone: Priority: low
Component: Translate Site & Plugins Keywords: needs-patch reporter-feedback
Cc:

Description

  • Some locales use numbered placeholders to change %s to %s into %2$s ba %1$s that shouldn't generate a GlotPress warning
  • Some originals use numbered placeholders such as %1$s to %2$s and translations simply use %s ba %s as long as the formats are in order in both and counts match, it shouldn't generate a warning.

Similar to #5154 & #5155

Change History (3)

#1 follow-up: @ocean90
7 months ago

  • Keywords reporter-feedback added

What’s the point of removing valid warnings just for translate.w.org? They exist for reasons. The second example should definitely be a warning because it’s an incorrect translation.

#2 in reply to: ↑ 1 @dd32
7 months ago

Replying to ocean90:

What’s the point of removing valid warnings just for translate.w.org?

I would be happy to upstream some improvements there, but your comment proves that it's not always viable either, The majority of the changes I make to translate is to improve the usability of it, rather than be "strictly correct" which the software should be.

However, I don't consider them to be valid warnings, warnings that will always be ignored/discarded are not warnings, they're notices at best.

You'd be correct in thinking that most translators will just fix the translation (because that's their only option other than leaving them), but from what I can see, many with editor rights simply discard them instead (even warnings which should never have been dismissed).

The second example should definitely be a warning because it’s an incorrect translation.

That's debatable IMHO, if it's being used with a printf library, it'll work just fine.

Perhaps a middle ground of agreeing that "upgrading" %s to %1$s shouldn't be considered a warning, but that downgrading is?

This ticket was mentioned in Slack in #polyglots by dd32. View the logs.


7 months ago

Note: See TracTickets for help on using tickets.