Opened 18 months ago

Last modified 13 months ago

#6588 new defect (bug)

Allow multiple changes on one topic edit

Reported by: sterndata's profile sterndata Owned by:
Milestone: Priority: normal
Component: Support Forums Keywords:


When modifying a post to change the forum (e.g., requests and feedback to fixing wordpress), changing the stats of the NSFW box at the same time gets lost if it's the same transaction.

Change History (6)

#1 @Otto42
18 months ago

I can think of no reason for that to occur. Does this only happen when you're moving a post between forums? Are any other fields, like the content, affected?

#2 @sterndata
18 months ago

No, it's only the checkbox for NSFW, as far as I can tell.

#3 @dd32
18 months ago

  • Component changed from General to Support Forums

I couldn't see any reason this would happen at first glance.. until I tested it.

The handler to move a topic between forums runs before the handler to set the NSFW flag.

In my testing, the operation to move between forums times out with a 504 error during the move, causing the NSFW flag handler to never run.

The order of operations is something like this:

  1. Update thread/reply contents
  2. Move topic to different forum
  3. Update topic replies to the new forum
  4. Recount forum thread counts for old and new forums <--- Times out here
  5. Process extra thread operations (Including the NSFW handler)

We'd need to figure out how to disable bbPress forum counting in order to fix this.

Move handler:

Interestingly, the wp-admin edit interface can move between forums without timing out, so I guess it might not run the recounts.. which would likely be a bbPress bug..

Last edited 18 months ago by dd32 (previous) (diff)

This ticket was mentioned in Slack in #forums by thelmachido. View the logs.

13 months ago

#5 @fierevere
13 months ago

#5669 was marked as a duplicate.

Note: See TracTickets for help on using tickets.