Allow multiple changes on one topic edit

[sterndata]

When modifying a post to change the forum (e.g., requests and feedback to fixing wordpress), changing the stats of the NSFW box at the same time gets lost if it's the same transaction.

[Otto42]

I can think of no reason for that to occur. Does this only happen when you're moving a post between forums? Are any other fields, like the content, affected?

[sterndata]

No, it's only the checkbox for NSFW, as far as I can tell.

[dd32]

I couldn't see any reason this would happen at first glance.. until I tested it.

The handler to move a topic between forums runs before the handler to set the NSFW flag.

In my testing, the operation to move between forums times out with a 504 error during the move, causing the NSFW flag handler to never run.

The order of operations is something like this:

1. Update thread/reply contents
2. Move topic to different forum
3. Update topic replies to the new forum
4. Recount forum thread counts for old and new forums <--- Times out here
5. Process extra thread operations (Including the NSFW handler)

We'd need to figure out how to disable bbPress forum counting in order to fix this.

Move handler: ​https://github.com/bbpress/bbPress/blob/394ae31c059228e866240076db2dc2ca2ddc8a7c/src/includes/topics/functions.php#L950-L1083

Interestingly, the wp-admin edit interface can move between forums without timing out, so I guess it might not run the recounts.. which would likely be a bbPress bug..

[fierevere]

#5669 was marked as a duplicate.

[fierevere]

related: #5669