Alphabetize rejection list in Photos

[topher1kenobe]

When you go to reject a photo there's a drop down list of reasons. It would be great if they were alphabetical

[topher1kenobe]

Screenshot of Rejection reasons not alphabetized.

[paulkevan]

I guess there is a reason for ordering them in this way (or maybe it's just how they have been added) - not sure if making them alphabetic is better, but they are just set within code here: ​https://github.com/WordPress/wordpress.org/blob/91fc0d424e513dc5bba990f3547fb8d1d0dff8be/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/rejection.php#L30-L107.

[coffee2code]

@topher1kenobe: Do you think it would be better to alphabetize the existing list, or to alphabetize the list after prepending each with a one-word token. The former would look like:

Do not reject
Collage or composite image
Contains human face(s)
Duplicate or minor variation of submitted photo
Image subject matter
Insufficient image quality (e.g. blurriness, composition, lighting, lens issues)
Not a photo (e.g. screenshot, digital art)
Overlays, watermark, borders, or other additions
Overprocessed
Potential copyright/ownership infringement
Potentially violates privacy
Predominantly another piece of art
Predominantly text
Prominent branding
Reason specified below
Submission error
Violence, gore, hate, or sexual content

And the latter would look like:

Do not reject
[Anothers Art] Predominantly another piece of art
[Branding] Prominent branding
[Collage] Collage or composite image
[Copyright] Potential copyright/ownership infringement
[Error] Submission error
[Extreme] Violence, gore, hate, or sexual content
[Faces] Contains human face(s)
[Not Photo] Not a photo (e.g. screenshot, digital art)
[Other]Reason specified below
[Overlays] Overlays, watermark, borders, or other additions
[Overprocessed] Overprocessed
[Privacy] Potentially violates privacy
[Quality] Insufficient image quality (e.g. blurriness, composition, lighting, lens issues)
[Subject] Image subject matter
[Text] Predominantly text
[Variation] Duplicate or minor variation of submitted photo

And if the brackets are too much noise, this example show colons and dashes:

Do not reject
Anothers Art: Predominantly another piece of art
Branding: Prominent branding
Collage: Collage or composite image
Copyright: Potential copyright/ownership infringement
Error: Submission error
Extreme: Violence, gore, hate, or sexual content
Faces: Contains human face(s)
Not Photo: Not a photo (e.g. screenshot, digital art)
Other - Reason specified below
Overlays - Overlays, watermark, borders, or other additions
Overprocessed - Overprocessed
Privacy - Potentially violates privacy
Quality - Insufficient image quality (e.g. blurriness, composition, lighting, lens issues)
Subject - Image subject matter
Text - Predominantly text
Variation - Duplicate or minor variation of submitted photo

[topher1kenobe]

I think I like the third option quite a lot.

[coffee2code]

@topher1kenobe: With colons or dashes?

[topher1kenobe]

I can't actually think of a reason it matters. Visually I like colons, but that's completely subjective.

[coffee2code]

In 12840:

Photo Directory, Rejection: Add prefix label to each rejection reason in dropdown and alphabetize the list.

Props topher1kenobe, coffee2code.
Fixes #7182.