WordPress.org

Making WordPress.org

Opened 6 years ago

Closed 6 years ago

#73 closed defect (fixed)

Blame link is broken in core Trac

Reported by: SergeyBiryukov Owned by: nacin
Milestone: Priority: low
Component: Trac Keywords:
Cc:

Change History (5)

#1 @iandunn
6 years ago

  • Owner set to nacin
  • Status changed from new to assigned

#2 @dd32
6 years ago

The info I could glean about this was posted over here: http://core.trac.wordpress.org/ticket/24976#comment:14

 Seems something funny is going on in Trac

 For example, on http://core.trac.wordpress.org/browser/trunk/src/wp-
 includes/admin-bar.php the Blame link lacks the {{{src/}}} path, however
 the Previous Revision link works (and it links to the non-src/ url, as
 that's where the file was at the time).

 But then take a file that's been modified since the move, such as
 http://core.trac.wordpress.org/browser/trunk/src/wp-includes/script-
 loader.php, and the Blame link is fine, but the Previous Revision link is
 missing.

#3 @nacin
6 years ago

So, this is almost certainly a Trac bug where the Blame link improperly follows copies (which it should only do if it is putting a revision in the URL).

And then the Previous Revision link appears to improperly not follow copies.

#4 @SergeyBiryukov
6 years ago

  • Description modified (diff)

#5 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

We fixed this a while ago using rewrite rules.

Note: See TracTickets for help on using tickets.