WordPress.org

Making WordPress.org

Opened 3 years ago

Last modified 4 weeks ago

#974 assigned enhancement

Make WordPress.tv theme responsive

Reported by: BrashRebel Owned by:
Milestone: Priority: normal
Component: WordPress.tv Keywords: good-first-bug has-patch ui-feedback
Cc:

Description

Seems to me there's no reason why this awesome site shouldn't have an awesome mobile experience.

Attachments (3)

974.diff (1.5 MB) - added by BrashRebel 3 years ago.
Theme adjustments to make wordpress.tv responsive
974.2.diff (15.5 KB) - added by iandunn 3 years ago.
974.3.patch (12.2 KB) - added by BrashRebel 18 months ago.
Fixed some CSS issues in the header, sidebar, upload page and featured video section.

Download all attachments as: .zip

Change History (17)

#1 @iandunn
3 years ago

  • Keywords needs-patch good-first-bug added
  • Owner set to iandunn
  • Status changed from new to accepted

+1

This ticket was mentioned in Slack in #wptv by brashrebel. View the logs.


3 years ago

@BrashRebel
3 years ago

Theme adjustments to make wordpress.tv responsive

#3 @BrashRebel
3 years ago

  • Cc kyle@… added
  • Keywords has-patch dev-feedback added; needs-patch removed

I just uploaded a huge patch. Includes lots of theme changes but all are 100% focused on making the existing theme adapt to smaller screen sizes (other than one deprecated function which I replaced).

I'm not 100% certain that this 974.diff file includes everything and was created properly. Sorry. Still not very experienced at generating diffs. If there are issues with the diff just let me know and I'll try and generate it again some other way.

This ticket was mentioned in Slack in #wptv by brashrebel. View the logs.


3 years ago

#5 @iandunn
3 years ago

It looks like the patch contains full copies of the files, rather than just the deltas, and it has Git style prefixes, so applying it created a second folder, but I was able to get it working by diff'ing that folder against the canonical one.

I think using git-svn to clone the repo, and then generating the diff with --no-prefix would result in a more workable patch. e.g.,

git svn clone https://meta.svn.wordpress.org/sites/trunk/wordpress.tv/public_html/wp-content/
git diff --no-prefix > ticket.diff

http://scribu.net/wordpress/contributing-to-wordpress-using-github.html might have some more tips (although we don't have a Git mirror for meta.svn like we do for core.svn, hence using git-svn to clone the actual SVN repo).

I've already got this one working, though, so no need to do that for this ticket.

#6 @iandunn
3 years ago

In 1556:

WordPress.tv: Replace deprecated like_escape with wpdb::esc_like.

See #974
Props BrashRebel

#7 @iandunn
3 years ago

974.diff is a really good first step, it solves most of the problems, but I think there's some more work to do before it's finished.

I made some changes to get us a little closer:

  • Replaced the accordion menu with the _s equivalent. The accordion wasn't working for me in Firefox, and it duplicates the markup and doesn't have the accessibility features that the _s one does. I also styled the menu a bit, but it could definitely be improved further.
  • Centered the list items at smaller resolutions, to make them easier to read.
  • Made the widgets use more of the empty space at tablet-sized resolutions.

I also left some todo notes with a few things that I noticed aren't working, but didn't have time to fix.

  • The video player is collapsing when the video starts to play, because of messing w/ the container height. I think some of my changes may have made this worse :) It may be better to stick with a fixed width and just center the player, instead of trying to make it grow/shrink w/ the viewport.
  • Secondary videos are overflowing their containers on small screens, because of the janky way they were originally setup w/ absolutely positioned thumbnails and padding to push the title over.
  • I think there'll be a few more things that come up in testing, but nothing major.

I committed a few small things, and then generated a new patch with my changes.

@iandunn
3 years ago

This ticket was mentioned in Slack in #wptv by brashrebel. View the logs.


3 years ago

#9 @iandunn
3 years ago

  • Keywords needs-patch added; has-patch dev-feedback removed

@BrashRebel
18 months ago

Fixed some CSS issues in the header, sidebar, upload page and featured video section.

#10 @melchoyce
10 months ago

  • Keywords has-patch ui-feedback added; needs-patch removed

#11 @iandunn
7 months ago

  • Owner iandunn deleted
  • Status changed from accepted to assigned

This ticket was mentioned in Slack in #meta-wordcamp by sergey. View the logs.


7 months ago

This ticket was mentioned in Slack in #meta by obenland. View the logs.


4 months ago

This ticket was mentioned in Slack in #meta by sergey. View the logs.


4 weeks ago

Note: See TracTickets for help on using tickets.