Forums theme: Forum link in header has wrong URL

[jubstuff]

Hello,

in the ​Italian forums the <h2> in the header points to ​http://it.wordpress.org/forums/forums/ and not to the correct URL ​http://it.wordpress.org/forums/.

[netweb]

Thanks @jubstuff, though I cannot reproduce this:

• The Forum link on the forums home page ​https://it.wordpress.org/forums/ is correct ​https://it.wordpress.org/forums/

• The Forum link from a single forum ​https://it.wordpress.org/forums/forum/guide-e-soluzioni/ is correct ​https://it.wordpress.org/forums/

• The Forum link from a single topic ​https://it.wordpress.org/forums/topic/benvenuto-nel-forum-dinstallazione-di-wordpress/ is correct ​https://it.wordpress.org/forums/

• The Forum link from a view ​https://it.wordpress.org/forums/view/popular/ is correct ​https://it.wordpress.org/forums/

• The Forum link from a topic tag ​https://it.wordpress.org/forums/topic-tag/top5/ is correct ​https://it.wordpress.org/forums/

[jubstuff]

Hello @netweb,

Thank you for your checks.
This morning it was wrong. Now it's correct! Maybe someone fixed this?

[netweb]

There was a "behind the scenes" change ~36 hours ago here that may have fixed it, or may have been a cache issue.

I'm going to close this ticket, if the same thing resurfaces feel free to reopen it.

[ocean90]

I fixed this a fre hours ago. This seems to be a bug in bbPress which I want to investigate first, reopening.

[netweb]

Replying to ocean90:

I fixed this a fre hours ago. This seems to be a bug in bbPress which I want to investigate first, reopening.

Not so much a bug, more a configuration issue of how the site is setup, I think, most likely related to the "forum root slug", the "page" being used for the "forums" or the "template" page being used for the forums, or a combination of these:

Dashboard -> Settings -> Forums -> Forum Root Slug -> Forum Root set to support <- wordpress.org/support
Dashboard -> Pages -> Edit the 'Forums' page and select the page template bbPress - Support (Index) and save the page
Dashboard -> Settings -> Reading -> Select a 'Static Page' for the 'Front Page' and select Forums

The above is taken from the "original setup instructions" as we were developing the theme and attempting to replicate the environment before we had the VVV WP-Meta environment to help: ​https://github.com/bbpress/wpbbp#bbpress-2x-configuration

[ocean90]

We don't need a forum root since "forums" is the path of the site. _bbp_include_root is disabled, _bbp_root_slug shows in the settings "forums". But I'm sure it's not the current value because when I save the settings again I get http://it.wordpress.org/forums/forums/. Entering something invalid like a "/" and make the home URL ​http://it.wordpress.org/forums/ again.

[netweb]

Right, the site root is https://it.wordpress.org/forums, so both _bbp_include_root and _bbp_root_slug should be disabled.

Currently as the site root is https://it.wordpress.org/forums then adding the _bbp_root_slug of forums that is how we end up with https://it.wordpress.org/forums/forums, I think ;)

[ocean90]

bbPress doesn't allow me to make _bbp_root_slug empty, it reverts to "forums". That's why I add a "/" to the field.

[ocean90]

Related: #1127

[ocean90]

In 1753:

Forums Theme: Use home_url() for forums link in header.

bbp_forums_url() returns the root slug too, which we don't want here.

fixes #1135.