Plugin Directory: Translation needed banner omits language

[Ipstenu]

Go to ​https://srd.wordpress.org/plugins/wordpress-seo/

Text reads: This plugin is not available in yet. Help translate it!

Whoops :D Happens on all plugins - ​https://srd.wordpress.org/plugins/akismet/ for example.

See image for more details.

[Ipstenu]

Example of error

[samuelsidler]

That site also appears to have a design issue in the subnav (in Safari at least). Something strange is going on there. /cc @ocean90 since he worked on the translation banner.

[SergeyBiryukov]

Related: #2517 (same issue for ​http://sah.wordpress.org/ in general WP.org banner).

Looks like there are some locales with empty language name.

[SergeyBiryukov]

Replying to samuelsidler:

That site also appears to have a design issue in the subnav (in Safari at least).

It's because the site doesn't have a nav menu, so it falls back to wp_page_menu(), which has a bit different markup (it doesn't have an option to omit the container, see ​#WP33974):

<div id="wporg-header-menu" class="menu">
	<ul>
		...
	</ul>
</div>

vs.

<ul id="wporg-header-menu" class="menu">
	...
</ul>

I guess there might be other inactive or empty Rosetta sites with the same issue, so 2618.patch​ fixes that in wp4.css: 2618.wporg-header-menu.PNG​.

I'd have to take another look to see why the Blog page is marked as current, but it would probably be easier to just create a proper menu for that site :)

[SergeyBiryukov]

Replying to SergeyBiryukov:

Replying to samuelsidler:

That site also appears to have a design issue in the subnav (in Safari at least).

It's because the site doesn't have a nav menu, so it falls back to wp_page_menu()

Moved to a separate ticket: #2769.

[SergeyBiryukov]

2618.2.patch​ is a patch for the initial issue with an empty link in locale banner. It follows the same approach as in [5371] and replaces direct queries to locales and languages tables with get_sites().

[SergeyBiryukov]

@ocean90: Anything I can do to help move 2618.2.patch​ forward?

[ocean90]

Yeah, we're not going to use the name of a site for the banner. See https://meta.trac.wordpress.org/ticket/2517#comment:2

[joostdevalk]

Simpler patch

[joostdevalk]

I've done a simpler version of the patch, using the GlotPress locales to grab the language name, @ocean90 can you review?

[Presskopp]

#3110 was marked as a duplicate.

[SergeyBiryukov]

In 6029:

Plugin Directory: Pull native language names for the locale banner from GP_Locales instead of the languages table.

Props joostdevalk.
Fixes #2618.