WordPress.org

Making WordPress.org

Opened 9 months ago

Closed 2 months ago

#2618 closed defect (fixed)

Plugin Directory: Translation needed banner omits language

Reported by: Ipstenu Owned by: SergeyBiryukov
Milestone: Plugin Directory v3.0 Priority: normal
Component: Plugin Directory Keywords:
Cc:

Description

Go to https://srd.wordpress.org/plugins/wordpress-seo/

Text reads: This plugin is not available in yet. Help translate it!

Whoops :D Happens on all plugins - https://srd.wordpress.org/plugins/akismet/ for example.

See image for more details.

Attachments (5)

Yoast_SEO_–_Plugin_Directory_—_WordPress.png (975.1 KB) - added by Ipstenu 9 months ago.
Example of error
2618.patch (902 bytes) - added by SergeyBiryukov 9 months ago.
2618.wporg-header-menu.PNG (21.0 KB) - added by SergeyBiryukov 9 months ago.
2618.2.patch (5.4 KB) - added by SergeyBiryukov 8 months ago.
locale-banner.patch (2.1 KB) - added by joostdevalk 6 months ago.
Simpler patch

Download all attachments as: .zip

Change History (19)

#1 follow-up: @samuelsidler
9 months ago

That site also appears to have a design issue in the subnav (in Safari at least). Something strange is going on there. /cc @ocean90 since he worked on the translation banner.

#2 @SergeyBiryukov
9 months ago

Related: #2517 (same issue for http://sah.wordpress.org/ in general WP.org banner).

Looks like there are some locales with empty language name.

#3 in reply to: ↑ 1 ; follow-up: @SergeyBiryukov
9 months ago

Replying to samuelsidler:

That site also appears to have a design issue in the subnav (in Safari at least).

It's because the site doesn't have a nav menu, so it falls back to wp_page_menu(), which has a bit different markup (it doesn't have an option to omit the container, see #WP33974):

<div id="wporg-header-menu" class="menu">
	<ul>
		...
	</ul>
</div>

vs.

<ul id="wporg-header-menu" class="menu">
	...
</ul>

I guess there might be other inactive or empty Rosetta sites with the same issue, so 2618.patch fixes that in wp4.css: 2618.wporg-header-menu.PNG.

I'd have to take another look to see why the Blog page is marked as current, but it would probably be easier to just create a proper menu for that site :)

This ticket was mentioned in Slack in #meta by sergey. View the logs.


9 months ago

#5 in reply to: ↑ 3 @SergeyBiryukov
8 months ago

Replying to SergeyBiryukov:

Replying to samuelsidler:

That site also appears to have a design issue in the subnav (in Safari at least).

It's because the site doesn't have a nav menu, so it falls back to wp_page_menu()

Moved to a separate ticket: #2769.

#6 @SergeyBiryukov
8 months ago

  • Keywords has-patch added; needs-patch removed

2618.2.patch is a patch for the initial issue with an empty link in locale banner. It follows the same approach as in [5371] and replaces direct queries to locales and languages tables with get_sites().

This ticket was mentioned in Slack in #forums by sergey. View the logs.


8 months ago

#8 @SergeyBiryukov
7 months ago

@ocean90: Anything I can do to help move 2618.2.patch forward?

#9 @ocean90
7 months ago

  • Keywords has-patch removed

Yeah, we're not going to use the name of a site for the banner. See https://meta.trac.wordpress.org/ticket/2517#comment:2

@joostdevalk
6 months ago

Simpler patch

#10 @joostdevalk
6 months ago

I've done a simpler version of the patch, using the GlotPress locales to grab the language name, @ocean90 can you review?

This ticket was mentioned in Slack in #meta by otto42. View the logs.


6 months ago

#12 @Presskopp
3 months ago

#3110 was marked as a duplicate.

#13 @SergeyBiryukov
3 months ago

  • Milestone changed from Plugin Directory v3 - Future to Plugin Directory v3.0

#14 @SergeyBiryukov
2 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 6029:

Plugin Directory: Pull native language names for the locale banner from GP_Locales instead of the languages table.

Props joostdevalk.
Fixes #2618.

Note: See TracTickets for help on using tickets.