Anchor id not sanitized

[sebastienserre]

Hello,

We have a problem in the French documentation team with the id in the doc title.
As you may know, in French we have specials characters which need to be sanitized before being used in an URL.

Example:
the page ​https://fr.wordpress.org/support/article/faq-troubleshooting/#indésirablesspams will produce the really ugly ​https://fr.wordpress.org/support/article/faq-troubleshooting/#ind%c3%a9sirablesspams

It should be great if the id used to create the HTML anchor should be sanitized thanks to sanitize_title().

[sebastienserre]

By checking the code, ​https://github.com/WordPress/wordpress.org/blob/1700e58c5b77172dc118670903f7636d592a0a46/wordpress.org/public_html/wp-content/plugins/handbook/inc/table-of-contents.php#L95 the id seems to be sanitized, so maybe it's a problem with ​https://developer.wordpress.org/reference/functions/sanitize_title_with_dashes/ ?

[dd32]

Replying to sebastienserre:

sanitize_title_with_dashes is doing what it's intended to, the problem is that it's expected to have accents removed/replaced prior to calling it.

The appropriate code would be sanitize_title_with_dashes( remove_accents( $title ) ) or potentially just sanitize_title( $title ) which does the same thing, but with a more filtered list of slug creation filters.

[dd32]

In 10920:

Handbooks/HelpHub: Replace accented characters before converting a title into a slug for use as page anchors.

Fixes #5711.

[dd32]

Pushed [10920] upstream in ​https://github.com/WordPress/HelpHub/commit/714bdcea78ebcc32217632a7129184d686c545f3

[sebastienserre]

Thank you @dd32 for the explanation and the correction.

[sebastienserre]

I wonder if sanitize_title() shouldn't be used as we can find as @papicx in the french doc: ​https://fr.wordpress.org/support/article/introduction-to-blogging/#les-slugs-d%e2%80%99articles

I think using sanitize_title() should solve this. What do you think @dd32 ?

[papicx]

and this one with non-breaking spaces and double quotes entering and leaving
​https://fr.wordpress.org/support/article/introduction-to-blogging/#qu%e2%80%99est-ce-qu%e2%80%99un-%c2%abblog%c2%bb

[sebastienserre]

@audrasjb suggests us on French Slack: ​https://developer.wordpress.org/reference/functions/sanitize_file_name/ which cover non-breaking-spaces and double-quotes

[audrasjb]

remove_accents (or sanitize_title) doesn't handle curly apostrophes, so maybe it would be better to use sanitize_file_name (see this Core ticket ​https://core.trac.wordpress.org/ticket/50231).

[sebastienserre]

Hello @dd32

Do you think, we could use sanitize_file_name ?

Many thanks

[dd32]

In 10945:

Handbooks/HelpHub: Replace accented characters before converting a title into a slug for use as page anchors. Take Two.

This time use sanitize_title() so that sanitize_title_with_dashes() gets called with save context rather than display which properly strips any remaining entities.

Follow up to [10920].
Fixes #5711.